Review main Abandoned

86656[TASK] Update browse-files.ts DOM Text Interpreted as HTML

TYPO3com CR 0 V 0 Easy +1 −1 updated 10/21/24, 07:43

Commit message

Description:
By using textContent, it will avoid the risk of HTML injection, as these
properties automatically escape any HTML special characters in the
provided text.
This helps make page more safer as compare to innerHTML and prevent
cross-site scripting (XSS) vulnerabilities by treating the input as plain
text rather than interpreted HTML.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 24

  1. TYPO3com uploaded patch set 1 10/19/24, 10:40

  2. core-ci voted on patch set 1 V -1 10/19/24, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68222

  3. Garvin Hicking commented on patch set 1 CR -1 10/19/24, 20:13

    This code loads actual raw HTML for the FAL inline image picker. The endpoint delivers HTML which needs insertion.
  4. Garvin Hicking abandoned the change 10/21/24, 07:43