Review main Abandoned

86657[TASK] Update deferred-action.ts DOM Text Interpreted as HTML

TYPO3com CR 0 V 0 Easy +1 −1 updated 10/21/24, 06:44

Commit message

Description:
By using textContent, it will avoid the risk of HTML injection, as these
properties automatically escape any HTML special characters in the
provided text.
This helps make page more safer as compare to innerHTML and prevent
cross-site scripting (XSS) vulnerabilities by treating the input as plain
text rather than interpreted HTML.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 10/19/24, 10:42

  2. core-ci voted on patch set 1 V -1 10/19/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68223

  3. Shivam Tiwari voted on patch set 1 CR +1 V +1 10/21/24, 03:28

  4. Andreas Kienast commented on patch set 1 V -1 10/21/24, 05:55

    This won't work as we inject HTML on purpose here.
  5. Andreas Kienast abandoned the change 10/21/24, 06:44