Review main Abandoned

86662[FEATURE] Display values in BE-forms like they get stored after `FormEngineValidation`-processing

Ayke Halder CR 0 V 0 Normal +46 −10 updated 10/29/24, 14:09

Commit message

Some values validated by `FormEngineValidation` are
background-converted or get lost while being transfered into its
hidden input-field and thereby also 'wrongly' stored in db (= save).

Whatever is visible in the backend MUST be identically saved into db.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 57

  1. Ayke Halder uploaded patch set 1 10/19/24, 21:11

  2. core-ci voted on patch set 1 V +1 10/19/24, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68237

  3. Ayke Halder rebased onto patch set 2 V +1 10/20/24, 12:59

  4. core-ci voted on patch set 2 V +1 10/20/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68261

  5. Benjamin Franzke commented on patch set 2 CR -1 10/28/24, 08:08

    form-engine-validation.ts:137 Unresolved

    This is an ugly hack for pretty bad behaviour by firefox. …but I'm not happy to ship that to chrome which works properly (it's not a bug that it allows exponential numbers)

    form-engine-validation.ts:140

    We should explicitly check of an empty string and only set an empty string in that case, otherwise we would be resetting values when values are invalid because of min/max boundaries. Also we should probably do this in the `invalid` event
  6. Ayke Halder commented on patch set 2 10/29/24, 14:08

    This change is ready for review.

    form-engine-validation.ts:140 Reply Unresolved

    Just as reference before closing this: https://developer.mozilla.org/en-US/docs/Web/API/ValidityState/badInput We can further refine the check by checking for `humanReadableField.validity?.badInput? === true`
  7. Ayke Halder abandoned the change 10/29/24, 14:09