86665[BUGFIX] Report native field validation errors in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #105368Form input fields that have native browser validation do not get marked as invalid but still block any saving of a record
- Task #105524FormEngine: input fields of type number are not working as expected when browser-native validation gets "bad input"
- Bug #107495FormEngine flexform section validation not properly indicating errors for type=email
- Bug #110500Backend form tabs containing invalid field values are not highlighted
- Task #105526Introduce test-option for FormEngineValidation
Files 4
Review log 3352
Show 1527 earlier messages
-
Ayke Halder uploaded patch set 1 10/20/24, 16:53
-
core-ci voted on patch set 1 V +1 10/20/24, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68263
-
Ayke Halder uploaded patch set 2
V +110/20/24, 18:39 -
core-ci voted on patch set 2 V -1 10/20/24, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68264
-
Ayke Halder uploaded patch set 3
V -110/20/24, 18:58 -
core-ci voted on patch set 3 V +1 10/20/24, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68265
-
Ayke Halder uploaded patch set 4
V +110/29/24, 19:18 -
core-ci voted on patch set 4 V +1 10/29/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68803
-
Ayke Halder uploaded patch set 5
V +110/30/24, 21:48 -
core-ci voted on patch set 5 V +1 10/30/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68868
-
Ayke Halder uploaded patch set 6
V +110/30/24, 22:17 -
Ayke Halder rebased onto patch set 7 10/30/24, 22:19
-
core-ci voted on patch set 6 V -1 10/30/24, 22:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68871
-
core-ci voted on patch set 7 V -1 10/30/24, 22:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68873
-
Ayke Halder rebased onto patch set 8
V -110/30/24, 22:53 -
core-ci voted on patch set 8 V +1 10/30/24, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68875
-
Ayke Halder rebased onto patch set 9
V +110/30/24, 23:01 -
core-ci voted on patch set 9 V +1 10/30/24, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68877
-
Ayke Halder uploaded patch set 10
V +110/31/24, 17:33 -
core-ci voted on patch set 10 V +1 10/31/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68936
-
Ayke Halder uploaded patch set 11
V +111/21/24, 10:51 -
core-ci voted on patch set 11 V +1 11/21/24, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69918
-
Andreas Kienast uploaded patch set 12
V +111/21/24, 13:03 -
core-ci voted on patch set 12 V -1 11/21/24, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69942
-
Ayke Halder commented on patch set 12 11/21/24, 13:23
-
Ayke Halder commented on patch set 12 11/21/24, 13:27
ElementsBasicEmailCest.php:109ReplyCorrect reference: https://git.typo3.org/typo3/CI/cms/-/jobs/3994565 ``` 1) ElementsBasicEmailCest: Email fields validation | "email_1",[{"inputValue":"","expectedValue":"","expectedInternalValue":"","expectError":false},{...] Test Acceptance/Application/FormEngine/ElementsBasicEmailCest.php:emailFieldsValidation Step Assert not contains "has-error",["form-control","form-control-clearable","t3js-clearable","has-change","has-error"],"Form field should not be marked as invalid" Fail Form field should not be marked as invalid Failed asserting that an array does not contain 'has-error'. . ``` -
Ayke Halder commented on patch set 12 11/21/24, 13:38
form-engine-validation.ts:204One small thing I'd like to change in the end, when everything else in this patch is working: * Replace `let markParent = false;` by `let isValid = true;` here. * Change all usages of `markParent` inside this function. * Finally remove `const isValid = !markParent;` at the end of this function.
-
Andreas Kienast commented on patch set 12 11/21/24, 13:50
ElementsBasicEmailCest.php:109ReplyThe test that bugs me the most is `ElementsBasicNumberCest.php`. For whatever reason, it keeps failing in the last sequence run when it attempts to replace the invalid `1-2` value if a valid empty string value. The screenshots reveal that the field remains invalid. I'll push the current state nevertheless to rule out an issue with seleniarm. -
Andreas Kienast uploaded patch set 13
V -111/21/24, 13:50 -
core-ci voted on patch set 13 V -1 11/21/24, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69944
-
Ayke Halder commented on patch set 13 11/21/24, 14:04
ElementsBasicEmailCest.php:109ReplySomehow the problem triggered here with `ElementsBasicNumberCest.php` is something that I intended to fix by a separate change: 86842: [BUGFIX] Handle browser-native validation-error `bad input` in form validation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86842 -
Andreas Kienast commented on patch set 13 11/21/24, 14:08
ElementsBasicEmailCest.php:109ReplyConfirmed, applying this patch on tops solves the issue! I'll read the patch thoroughly and merge it with this one. -
Ayke Halder commented on patch set 13 11/21/24, 14:11
ElementsBasicEmailCest.php:109ReplyMy point here is, that Patchset 11 of this patch worked: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86665/11 So I still intend to keep the issues seperate. Can I do a new rebase of this Patchset 11 onto main - and we see if it still works as intended? -
Andreas Kienast uploaded patch set 14
V -111/21/24, 14:13 -
Andreas Kienast commented on patch set 14 11/21/24, 14:17
ElementsBasicEmailCest.php:109ReplyFine for me. -
Andreas Kienast uploaded patch set 15 11/21/24, 14:17
-
core-ci voted on patch set 14 V +1 11/21/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69948
-
core-ci voted on patch set 15 V +1 11/21/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69949
-
Andreas Kienast uploaded patch set 16
V +111/21/24, 14:29 -
Ayke Halder commented on patch set 15 11/21/24, 14:30
ElementsBasicEmailCest.php:109ReplyThis looks good again! Patchset 11 and 15 are kind of identical: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86665/11..15 I'll do a rebase for the follow-up issue itself: 86842: [BUGFIX] Handle browser-native validation-error `bad input` in form validation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86842 -
core-ci voted on patch set 16 V +1 11/21/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69951
-
Andreas Kienast voted on patch set 16 CR +1 V +1 11/21/24, 14:36
-
Ayke Halder commented on patch set 16 11/21/24, 14:43
form-engine-validation.ts:204ReplyDone. And thanks for implementing this. -
Benni Mack updated the commit message in patch set 17
CR +1V +104/22/26, 06:30 -
core-ci voted on patch set 17 V -1 04/22/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100717
-
Benni Mack uploaded patch set 18
V -111/11/26, 11:50 -
Benni Mack uploaded patch set 19 11/11/26, 12:33
-
core-ci voted on patch set 18 V +1 11/11/26, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114067
-
core-ci voted on patch set 19 V +1 11/11/26, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114071
-
Benni Mack voted on patch set 19 CR +1 V +1 11/11/26, 12:44
-
Georg Ringer voted on patch set 19 CR +2 V +2 11/11/26, 12:45
-
Georg Ringer merged patch set 20 11/11/26, 13:24
ElementsBasicEmailCest.php:109