Review main Merged

86674[BUGFIX] Use pid of mount point in RootlineUtility

Markus Friedrich CR +2 V +2 Normal +146 −61 updated 11/18/24, 22:07

Commit message

RootlineUtility uses the pid of the mounted pages to build the
rootline, which e.g. leads to wrong site configuration and TypoScript
usage.

Using the pid of the mount point solves the issues and restores the
previous behavior

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1418

  1. Markus Friedrich uploaded patch set 1 10/21/24, 12:19

  2. core-ci voted on patch set 1 V +1 10/21/24, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68302

  3. Benni Mack updated the commit message in patch set 2 V +1 10/21/24, 13:44

  4. Christian Kuhn commented on patch set 2 10/21/24, 13:47

    thank you! i will have a look at this with stefan, hopefully next week. looks as if coverage is not good enough in this area, so we should improve it with this patch to verify details.
  5. core-ci voted on patch set 2 V +1 10/21/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68311

  6. Benni Mack commented on patch set 2 CR +1 V +1 11/14/24, 07:33

    Reply

    Checked this with 11.5 -> the change is legit. This line from Markus was exactly like it was until v13.
  7. Christian Kuhn commented on patch set 2 11/18/24, 18:08

    RootlineUtility.php:432

    i think we probably should re-introduce the unset() call that was here, previously.
  8. Christian Kuhn uploaded patch set 3 CR +1 V +1 11/18/24, 18:15

  9. Christian Kuhn commented on patch set 3 11/18/24, 18:18

    Reply

    Confirmed. Looking at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85374/26/typo3/sysext/core/Classes/Utility/RootlineUtility.php#429 this seems to be an oversight in the patch. I also added the unset() back in. I had a hard time trying to add a functional test on it, so I'll ping stefan buerk, if we could go with this change for now, it seems we need better coverage of the "outer" mount point stuff (current test look at lower level tests only), and if we could add this with another patch, or if it should be added right with this one.
  10. Christian Kuhn commented on patch set 3 11/18/24, 18:19

    RootlineUtility.php:432 Reply

    Done
  11. core-ci voted on patch set 3 V +1 11/18/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69615

  12. Stefan Bürk uploaded patch set 4 V +1 11/18/24, 20:02

  13. Stefan Bürk commented on patch set 4 11/18/24, 20:09

    Reply

    Confirmed. I added at least some tests, which shows the difference. Following gist: https://gist.github.com/sbuerk/f921e90ea9d830c2a988ea7f397cbfe8 contains two diffs, one for main branch without this change (only the tests) and one for branch 13.1 (branch before cte has been merged in v13) with hash adoption for the sys_refindex entries) The 13.1 diff shows that it works the same as with this change, and the main diff without this change that it is broken. I'm not that deep into the mountpoint logic, so I guess we should add more coverages for it afterwards. But at least we have one showcasing that this issue is fixed, I would say.
  14. core-ci voted on patch set 4 V +1 11/18/24, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69622

  15. Stefan Bürk voted on patch set 4 CR +1 V +1 11/18/24, 20:14

  16. Christian Kuhn commented on patch set 4 CR +1 V +1 11/18/24, 21:58

    Reply

    Done. Nice. Thank you!
  17. Christian Kuhn voted on patch set 4 CR +2 V +2 11/18/24, 22:07

  18. Christian Kuhn merged patch set 5 11/18/24, 22:07