Review main Merged Breaking

86678[!!!][TASK] Remove deprecated icon size handling

Andreas Kienast CR +2 V +2 Normal +20 −152 updated 10/22/24, 17:25

Commit message

The following deprecated icon size constants have been removed:

* `\TYPO3\CMS\Core\Imaging\Icon::SIZE_DEFAULT`
* `\TYPO3\CMS\Core\Imaging\Icon::SIZE_LARGE`
* `\TYPO3\CMS\Core\Imaging\Icon::SIZE_MEDIUM`
* `\TYPO3\CMS\Core\Imaging\Icon::SIZE_MEGA`
* `\TYPO3\CMS\Core\Imaging\Icon::SIZE_SMALL`

The following class methods has been removed:

`\TYPO3\CMS\Core\Imaging\Event\ModifyIconForResourcePropertiesEvent->getSize()`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 1422

  1. Andreas Kienast uploaded patch set 1 10/21/24, 13:19

  2. Andreas Kienast updated the commit message in patch set 2 10/21/24, 13:19

  3. core-ci voted on patch set 1 V -1 10/21/24, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68306

  4. Andreas Kienast uploaded patch set 3 10/21/24, 13:27

  5. core-ci voted on patch set 2 V -1 10/21/24, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68307

  6. core-ci voted on patch set 3 V -1 10/21/24, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68308

  7. Andreas Kienast uploaded patch set 4 V -1 10/21/24, 13:40

  8. Andreas Kienast updated the commit message in patch set 5 10/21/24, 13:41

  9. core-ci voted on patch set 5 V -1 10/21/24, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68310

  10. core-ci commented on patch set 5 10/21/24, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68310

  11. Andreas Kienast uploaded patch set 6 V -1 10/21/24, 14:47

  12. core-ci voted on patch set 6 V +1 10/21/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68320

  13. Benni Mack updated the commit message in patch set 7 V +1 10/21/24, 15:01

  14. core-ci voted on patch set 7 V +1 10/21/24, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68321

  15. Anja Leichsenring voted on patch set 7 CR +1 V +1 10/22/24, 05:14

  16. Christian Kuhn voted on patch set 7 CR +1 V +1 10/22/24, 16:13

  17. Christian Kuhn uploaded patch set 8 CR +1 V +1 10/22/24, 16:16

  18. Christian Kuhn voted on patch set 8 CR +1 V +1 10/22/24, 16:16

  19. core-ci voted on patch set 8 V +1 10/22/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68383

  20. Anja Leichsenring voted on patch set 8 CR +1 V +1 10/22/24, 16:48

  21. Andreas Kienast voted on patch set 8 CR +2 V +2 10/22/24, 17:25

  22. Andreas Kienast merged patch set 9 10/22/24, 17:25