86679[!!!][TASK] Remove deprecated method returnWebmounts
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+0 −17
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst2+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php+0 −14
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php2+1 −0
Review log 1318
-
Thomas Hohn uploaded patch set 1 10/21/24, 14:42
-
Andreas Kienast commented on patch set 1 CR -1 10/21/24, 14:48
Please add the `Related` line with the patch that deprecated the method and also adjust the (hopefully) existing matcher for the static code check. -
core-ci voted on patch set 1 V +1 10/21/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68318
-
Thomas Hohn uploaded patch set 2
CR -1V +110/21/24, 15:29 -
Thomas Hohn commented on patch set 2 10/21/24, 15:30
Reply
Done -
core-ci voted on patch set 2 V +1 10/21/24, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68322
-
Christian Kuhn commented on patch set 2 10/21/24, 16:00
Breaking-105377-DeprecatedFunctionalityRemoved.rst:36i'd go with `->` since the method was not static.MethodCallStaticMatcher.php:1641don't remove this, but add the breaking.rst as second entry here. -
Thomas Hohn uploaded patch set 3
V +110/21/24, 16:08 -
Thomas Hohn commented on patch set 2 10/21/24, 16:08
Breaking-105377-DeprecatedFunctionalityRemoved.rst:36ReplyAcknowledgedMethodCallStaticMatcher.php:1641ReplyAcknowledged -
Christian Kuhn updated the commit message in patch set 4 10/21/24, 16:09
-
core-ci voted on patch set 3 V +1 10/21/24, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68327
-
Christian Kuhn voted on patch set 4 CR +1 V +1 10/21/24, 16:16
-
core-ci voted on patch set 4 V +1 10/21/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68328
-
Thomas Hohn updated the commit message in patch set 5
CR +1V +110/21/24, 19:58 -
core-ci voted on patch set 5 V +1 10/21/24, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68330
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 10/22/24, 05:10
-
Christian Kuhn voted on patch set 5 CR +2 V +2 10/22/24, 15:43
-
Christian Kuhn merged patch set 6 10/22/24, 15:43