Review main Merged Breaking

86679[!!!][TASK] Remove deprecated method returnWebmounts

Thomas Hohn CR +2 V +2 Easy +2 −32 updated 10/22/24, 15:43

Commit message

The class method `returnWebmounts` has been removed in class
`\TYPO3\CMS\Core\Authentication\BackendUserAuthentication`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1318

  1. Thomas Hohn uploaded patch set 1 10/21/24, 14:42

  2. Andreas Kienast commented on patch set 1 CR -1 10/21/24, 14:48

    Please add the `Related` line with the patch that deprecated the method and also adjust the (hopefully) existing matcher for the static code check.
  3. core-ci voted on patch set 1 V +1 10/21/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68318

  4. Thomas Hohn uploaded patch set 2 CR -1 V +1 10/21/24, 15:29

  5. Thomas Hohn commented on patch set 2 10/21/24, 15:30

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/21/24, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68322

  7. Christian Kuhn commented on patch set 2 10/21/24, 16:00

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:36

    i'd go with `->` since the method was not static.

    MethodCallStaticMatcher.php:1641

    don't remove this, but add the breaking.rst as second entry here.
  8. Thomas Hohn uploaded patch set 3 V +1 10/21/24, 16:08

  9. Thomas Hohn commented on patch set 2 10/21/24, 16:08

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:36 Reply

    Acknowledged

    MethodCallStaticMatcher.php:1641 Reply

    Acknowledged
  10. Christian Kuhn updated the commit message in patch set 4 10/21/24, 16:09

  11. core-ci voted on patch set 3 V +1 10/21/24, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68327

  12. Christian Kuhn voted on patch set 4 CR +1 V +1 10/21/24, 16:16

  13. core-ci voted on patch set 4 V +1 10/21/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68328

  14. Thomas Hohn updated the commit message in patch set 5 CR +1 V +1 10/21/24, 19:58

  15. core-ci voted on patch set 5 V +1 10/21/24, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68330

  16. Anja Leichsenring voted on patch set 5 CR +1 V +1 10/22/24, 05:10

  17. Christian Kuhn voted on patch set 5 CR +2 V +2 10/22/24, 15:43

  18. Christian Kuhn merged patch set 6 10/22/24, 15:43