86681[BUGFIX] Ensure same RecordIdentityMap for cloned PageLayoutContext
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 78
-
Nikita Hovratov uploaded patch set 1 10/21/24, 15:54
-
core-ci voted on patch set 1 V +1 10/21/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68324
-
Oli Bartsch commented on patch set 1 CR +1 V +1 10/21/24, 16:35
This works. However, in case we want to keep the lazy loading, we could just do ``` $copy->recordIdentityMap = $this->getRecordIdentityMap(); ``` -
Nikita Hovratov commented on patch set 1 10/21/24, 16:43
Reply
Let's see what Benni says. There is no huge benefit having it lazy load, or? -
Benni Mack commented on patch set 1 10/28/24, 13:19
Reply
fine like it is with this change -
Benni Mack voted on patch set 1 CR +1 V +1 10/28/24, 13:19
-
Oli Bartsch voted on patch set 1 CR +2 V +2 10/30/24, 16:14
-
Oli Bartsch merged patch set 2 10/30/24, 16:14