Review main Merged

86682[BUGFIX] Properly set columnMap relation for type "folder"

Oli Bartsch CR +2 V +2 Normal +86 −10 updated 10/23/24, 17:21

Commit message

TCA type "folder" is a special type since it's always
a relation but not to a table but one or more folder
identifier. This is now handled properly.

In previous versions, this was handled (by accident?)
since the $type (the FQN) matched a strpbrk() check,
which led to marking the relation as "toOne".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/21/24, 16:23

  2. core-ci voted on patch set 1 V +1 10/21/24, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68329

  3. Benni Mack voted on patch set 1 CR +1 V +1 10/22/24, 03:43

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 10/23/24, 15:44

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 10/23/24, 17:21

  6. Christian Kuhn merged patch set 2 10/23/24, 17:21