Review main Merged Breaking

86683[!!!][TASK] Remove deprecated AbstractFile::FILETYPE_* constants

Thomas Hohn CR +2 V +2 Normal +12 −41 updated 10/23/24, 16:03

Commit message

The following deprecated AbstractFile constants have been removed:

* `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_TEXT`
* `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_IMAGE`
* `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_AUDIO`
* `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_VIDEO`
* `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_APPLICATION`

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1420

  1. Thomas Hohn uploaded patch set 1 10/22/24, 04:49

  2. Thomas Hohn uploaded patch set 2 10/22/24, 04:51

  3. core-ci voted on patch set 1 V +1 10/22/24, 04:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68343

  4. core-ci voted on patch set 2 V +1 10/22/24, 04:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68344

  5. Thomas Hohn uploaded patch set 3 V +1 10/22/24, 17:32

  6. core-ci voted on patch set 3 V +1 10/22/24, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68393

  7. Garvin Hicking updated the commit message in patch set 4 V +1 10/23/24, 10:48

  8. Garvin Hicking commented on patch set 4 10/23/24, 10:50

    AbstractFile.php:76

    Was this left intentionally?
  9. Thomas Hohn commented on patch set 4 10/23/24, 10:51

    AbstractFile.php:76 Reply

    No - will fix it - nice catch 😊
  10. Thomas Hohn uploaded patch set 5 10/23/24, 10:54

  11. core-ci voted on patch set 4 V +1 10/23/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68442

  12. core-ci voted on patch set 5 V +1 10/23/24, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68443

  13. Garvin Hicking voted on patch set 5 CR +1 V +1 10/23/24, 11:08

  14. Thomas Hohn commented on patch set 5 10/23/24, 11:12

    AbstractFile.php:76 Reply

    Done
  15. Andreas Kienast uploaded patch set 6 CR +1 V +1 10/23/24, 12:18

  16. core-ci voted on patch set 6 V +1 10/23/24, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68450

  17. Andreas Kienast voted on patch set 6 CR +1 V +1 10/23/24, 12:35

  18. Garvin Hicking voted on patch set 6 CR +1 V +1 10/23/24, 16:02

  19. Garvin Hicking voted on patch set 6 CR +2 V +2 10/23/24, 16:03

  20. Garvin Hicking merged patch set 7 10/23/24, 16:03