Review main Merged Breaking

86684[!!!][TASK] Remove deprecations in VersionState

Thomas Hohn CR +2 V +2 Normal +4 −72 updated 10/24/24, 07:08

Commit message

The following class methods have been removed:

* `\TYPO3\CMS\Core\Versioning\VersionState::cast()`
* `\TYPO3\CMS\Core\Versioning\VersionState->equals()`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 2435

Show 510 earlier messages
  1. Thomas Hohn uploaded patch set 1 10/22/24, 05:38

  2. Thomas Hohn updated the commit message in patch set 2 10/22/24, 05:39

  3. core-ci voted on patch set 1 V -1 10/22/24, 05:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68347

  4. core-ci voted on patch set 2 V -1 10/22/24, 05:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68348

  5. Thomas Hohn uploaded patch set 3 V -1 10/22/24, 06:16

  6. core-ci voted on patch set 3 V +1 10/22/24, 06:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68350

  7. Thomas Hohn uploaded patch set 4 V +1 10/22/24, 16:27

  8. Thomas Hohn uploaded patch set 5 10/22/24, 16:29

  9. core-ci voted on patch set 4 V +1 10/22/24, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68386

  10. core-ci voted on patch set 5 V +1 10/22/24, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68388

  1. Thomas Hohn uploaded patch set 6 V +1 10/22/24, 17:30

  2. core-ci voted on patch set 6 V +1 10/22/24, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68392

  3. Garvin Hicking voted on patch set 6 CR +1 V +1 10/23/24, 10:47

  4. Thomas Hohn uploaded patch set 7 CR +1 V +1 10/23/24, 10:58

  5. core-ci voted on patch set 7 V +1 10/23/24, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68448

  6. Garvin Hicking voted on patch set 7 CR +1 V +1 10/23/24, 11:39

  7. Andreas Kienast commented on patch set 7 CR -1 10/23/24, 11:49

    VersionStateTest.php:25

    The whole test class tests PHP-native API now. The only custom logic in `VersionState` is the method `indicatesPlaceholder`.
  8. Andreas Kienast commented on patch set 7 10/23/24, 11:52

    VersionStateTest.php:63

    Additionally, this test became more unreliable as only the values are compared but not the equality of the enum class.
  9. Thomas Hohn uploaded patch set 8 CR +1 V +1 10/23/24, 12:19

  10. Thomas Hohn commented on patch set 8 10/23/24, 12:22

    VersionStateTest.php:25 Reply

    Hrm - update this path - let me now if I should revert the latest push and create a follow up patch
  11. core-ci voted on patch set 8 V +1 10/23/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68451

  12. Andreas Kienast commented on patch set 8 10/23/24, 13:43

    VersionStateTest.php:25 Reply

    It makes sense to have the test in older versions as well. I'll take care of this.
  13. Andreas Kienast commented on patch set 8 10/23/24, 13:50

  14. Andreas Kienast uploaded patch set 9 V +1 10/23/24, 18:10

  15. Andreas Kienast uploaded patch set 10 10/23/24, 18:10

  16. Andreas Kienast commented on patch set 10 10/23/24, 18:11

    VersionStateTest.php:25 Reply

    Done
  17. Andreas Kienast commented on patch set 10 10/23/24, 18:15

    VersionStateTest.php:63 Reply

    Done
  18. core-ci voted on patch set 9 V +1 10/23/24, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68478

  19. core-ci voted on patch set 10 V +1 10/23/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68479

  20. Andreas Kienast uploaded patch set 11 V +1 10/23/24, 18:55

  21. core-ci voted on patch set 11 V +1 10/23/24, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68481

  22. Andreas Kienast voted on patch set 11 CR +1 V +1 10/24/24, 06:12

  23. Garvin Hicking voted on patch set 11 CR +1 V +1 10/24/24, 06:20

  24. Andreas Kienast voted on patch set 11 CR +2 V +2 10/24/24, 07:08

  25. Andreas Kienast merged patch set 12 10/24/24, 07:08