Review main Merged

86691[BUGFIX] Revert visibility change of createValidator()

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/22/24, 15:25

Commit message

This reverts a visibility change of
AbstractRenderable->createValidator()
as this might break implementations
calling this method on custom renderables.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • Andreas Kienast +1
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 89

  1. Oli Bartsch uploaded patch set 1 10/22/24, 14:09

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 10/22/24, 14:12

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 10/22/24, 14:15

  4. core-ci voted on patch set 1 V +1 10/22/24, 14:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68372

  5. Mathias Brodala voted on patch set 1 CR +1 10/22/24, 14:23

  6. Garvin Hicking voted on patch set 1 CR +1 V +1 10/22/24, 14:30

  7. Benni Mack voted on patch set 1 CR +1 V +1 10/22/24, 15:22

  8. Oli Bartsch voted on patch set 1 CR +2 V +2 10/22/24, 15:24

  9. Oli Bartsch merged patch set 2 10/22/24, 15:25