Review main Merged

86693[BUGFIX] Properly check for TCA schema in DataMapFactory

Oli Bartsch CR +2 V +2 Easy +8 −8 updated 10/23/24, 15:38

Commit message

Prevent UndefinedSchemaException by checking
for the schema before calling getFields().

Since the same check was already present in
addMetaDataColumnNames(), the check is moved
to the buildDataMapInternal() method and instead
of the table name, is the resolved schema
given to addMetaDataColumnNames() now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/22/24, 15:24

  2. core-ci voted on patch set 1 V +1 10/22/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68378

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/22/24, 16:08

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/23/24, 15:12

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 10/23/24, 15:32

  6. Christian Kuhn merged patch set 2 10/23/24, 15:38