Review main Merged Breaking

86700[!!!][TASK] Remove deprecated class IconState

Thomas Hohn CR +2 V +2 Normal +7 −91 updated 10/23/24, 15:48

Commit message

Removed the deprecated class:
`\TYPO3\CMS\Core\Type\Icon\IconState`

Change signature of `\TYPO3\CMS\Core\Imaging\IconFactory->getIcon()`,
argument 4 is now of type `?\TYPO3\CMS\Core\Imaging\IconState`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1420

  1. Thomas Hohn uploaded patch set 1 10/23/24, 05:01

  2. core-ci voted on patch set 1 V -1 10/23/24, 05:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68416

  3. Thomas Hohn uploaded patch set 2 V -1 10/23/24, 05:11

  4. core-ci voted on patch set 2 V +1 10/23/24, 05:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68418

  5. Andreas Kienast commented on patch set 2 CR -1 10/23/24, 05:58

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:45

    I'd prefer to have the FQCN here. The removed enumeration was also called `IconState`.
  6. Thomas Hohn uploaded patch set 3 CR -1 V +1 10/23/24, 06:03

  7. Thomas Hohn commented on patch set 3 10/23/24, 06:04

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:45 Reply

    Acknowledged
  8. Andreas Kienast voted on patch set 3 CR +1 V +1 10/23/24, 06:04

  9. core-ci voted on patch set 3 V +1 10/23/24, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68421

  10. Thomas Hohn uploaded patch set 4 CR +1 V +1 10/23/24, 10:57

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 10/23/24, 10:59

  12. core-ci voted on patch set 4 V +1 10/23/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68447

  13. Thomas Hohn uploaded patch set 5 CR +1 V +1 10/23/24, 12:32

  14. Andreas Kienast commented on patch set 5 CR -1 10/23/24, 12:37

    on it
  15. core-ci voted on patch set 5 V +1 10/23/24, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68452

  16. Andreas Kienast uploaded patch set 6 CR -1 V +1 10/23/24, 12:54

  17. core-ci voted on patch set 6 V +1 10/23/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68453

  18. Andreas Kienast voted on patch set 6 CR +1 V +1 10/23/24, 12:59

  19. Christian Kuhn voted on patch set 6 CR +2 V +2 10/23/24, 15:48

  20. Christian Kuhn merged patch set 7 10/23/24, 15:48