86701[BUGFIX] Use correct dataset identifier for date ranges
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/Sass/component/_datetimepicker.scss+0 −5
- Build/Sources/TypeScript/backend/date-time-picker.ts3+6 −4
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+8 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
Review log 1215
-
Andreas Kienast uploaded patch set 1 10/23/24, 06:45
-
core-ci voted on patch set 1 V -1 10/23/24, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68427
-
Andreas Kienast uploaded patch set 2
V -110/23/24, 07:24 -
core-ci voted on patch set 2 V +1 10/23/24, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68429
-
Garvin Hicking voted on patch set 2 CR +1 V +1 10/24/24, 07:56
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/28/24, 11:55
-
Benjamin Franzke commented on patch set 2 CR -1 10/29/24, 12:51
-
Benjamin Franzke commented on patch set 2 10/29/24, 13:22
date-time-picker.ts:268ReplyCan easily tested by setting the value manually to the min value in the database, e.g. for the `inputdatetime_34` which is configured to have `1627208536` as min. That is in UTC: So 25. Jul 10:22:16 UTC 2021 ``` update tx_styleguide_elements_basic set inputdatetime_34 = 1627208536 where uid = 1; ``` When loading FormEngine on a server with timezone=UTC and a client with `timezone=Europe/Berlin`, the min value will be discarded and as the min value is interpreted as ``` So 25. Jul 12:22:16 CEST 2021 ``` Instead of ``` So 25. Jul 10:22:16 UTC 2021 ``` The client only allows to enter >= 12:22 instead of > 10:22 on the 25th of july 2021. -
Benjamin Franzke uploaded patch set 3
CR +1V +110/29/24, 16:05 -
Benjamin Franzke commented on patch set 3 10/29/24, 16:05
date-time-picker.ts:268ReplyDone -
Benjamin Franzke voted on patch set 3 CR +1 V +1 10/29/24, 16:06
-
core-ci voted on patch set 3 V +1 10/29/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68796
-
Garvin Hicking voted on patch set 3 CR +1 V +1 10/30/24, 09:40
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 10/30/24, 11:46
-
Benjamin Franzke merged patch set 4 10/30/24, 11:54
date-time-picker.ts:268