Review main Merged

86710[TASK] Remove stray `@todo` from IconSize deprecation removal

Andreas Kienast CR +2 V +2 Easy +0 −3 updated 10/23/24, 17:33

Commit message

During removal of the deprecated string-based icon sizes, an open
`@todo` annotation was forgotten.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 912

  1. Andreas Kienast uploaded patch set 1 10/23/24, 12:59

  2. core-ci voted on patch set 1 V +1 10/23/24, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68454

  3. Andreas Kienast updated the commit message in patch set 2 V +1 10/23/24, 13:07

  4. core-ci voted on patch set 2 V +1 10/23/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68455

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 10/23/24, 13:14

  6. Andreas Kienast uploaded patch set 3 CR +1 V +1 10/23/24, 13:23

  7. core-ci voted on patch set 3 V +1 10/23/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68457

  8. Christian Kuhn voted on patch set 3 CR +2 V +2 10/23/24, 17:27

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 10/23/24, 17:30

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 10/23/24, 17:32

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 10/23/24, 17:32

  12. Christian Kuhn merged patch set 4 10/23/24, 17:33