Review main Merged

86711[BUGFIX] Remove nullability from `$size` in `IF->getIconForRecord()`

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 10/23/24, 18:00

Commit message

This patch removes the nullability of the `$size` argument in
`getIconForRecord()` as it makes no sense at all and will lead to
errors when passed to `getIcon()`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1215

  1. Andreas Kienast uploaded patch set 1 10/23/24, 13:22

  2. Kevin Appelt voted on patch set 1 CR +1 V +1 10/23/24, 13:26

  3. core-ci voted on patch set 1 V +1 10/23/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68456

  4. Thomas Hohn voted on patch set 1 CR +1 V +1 10/23/24, 13:31

  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 10/23/24, 15:55

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 10/23/24, 15:55

  7. core-ci voted on patch set 2 V +1 10/23/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68465

  8. Kevin Appelt voted on patch set 2 CR +1 V +1 10/23/24, 16:02

  9. Andreas Kienast commented on patch set 2 CR -1 10/23/24, 16:04

    IconFactory.php:79

    This shouldn't go in this patch...
  10. Andreas Kienast uploaded patch set 3 CR +1 V +1 10/23/24, 16:05

  11. Garvin Hicking voted on patch set 3 CR +1 V +1 10/23/24, 16:07

  12. core-ci voted on patch set 3 V +1 10/23/24, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68467

  13. Christian Kuhn commented on patch set 3 CR +1 V +1 10/23/24, 16:13

    IconFactory.php:79 Reply

    Acknowledged
  14. Christian Kuhn voted on patch set 3 CR +2 V +2 10/23/24, 17:35

  15. Christian Kuhn merged patch set 4 10/23/24, 18:00