86712[TASK] Add tests for `VersionState->indicatesPlaceholder()`
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 56
-
Andreas Kienast uploaded patch set 1 10/23/24, 13:50
-
core-ci voted on patch set 1 V +1 10/23/24, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68458
-
Garvin Hicking commented on patch set 1 CR +1 V +1 10/23/24, 14:40
Wondered if it should be "canIndicatePlaceholder" or if its meant differently maybe canPlaceholderBeIndicated? Anyhow, naming things. Just casually giving feedback for a lonesome Rider, that isn't just "green" or "red" or +1 ;) -
Christian Kuhn voted on patch set 1 CR +1 V +1 10/23/24, 15:41
-
Andreas Kienast voted on patch set 1 CR +2 V +2 10/23/24, 15:51
-
Andreas Kienast merged patch set 2 10/23/24, 16:00