Review main Merged

86717[BUGFIX] Sort resolved file references

Nikita Hovratov CR +2 V +2 Normal +95 −5 updated 11/01/24, 19:24

Commit message

RelationResolver now correctly sorts found file references
after receiving the unordered list from GreedyDatabaseBackend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1116

  1. Nikita Hovratov uploaded patch set 1 10/23/24, 16:46

  2. core-ci voted on patch set 1 V -1 10/23/24, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68471

  3. Oli Bartsch commented on patch set 1 10/23/24, 17:47

    GreedyDatabaseBackend.php:107

    What do you think about moving this topic to the calling code, since the class explicitly states that it does not do sorting?
  4. Nikita Hovratov uploaded patch set 2 V -1 10/25/24, 17:53

  5. Nikita Hovratov commented on patch set 2 10/25/24, 17:55

    GreedyDatabaseBackend.php:107 Reply

    Done
  6. core-ci voted on patch set 2 V -1 10/25/24, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68638

  7. Nikita Hovratov uploaded patch set 3 V -1 10/25/24, 18:07

  8. core-ci voted on patch set 3 V +1 10/25/24, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68639

  9. Nikita Hovratov uploaded patch set 4 V +1 10/25/24, 18:46

  10. Nikita Hovratov updated the commit message in patch set 5 10/25/24, 18:47

  11. core-ci voted on patch set 4 V +1 10/25/24, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68640

  12. core-ci voted on patch set 5 V +1 10/25/24, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68641

  13. Benni Mack voted on patch set 5 CR +1 V +1 10/25/24, 20:40

  14. Simon Schaufelberger voted on patch set 5 CR +1 V +1 10/31/24, 09:11

  15. Benni Mack voted on patch set 5 CR +2 V +2 11/01/24, 19:24

  16. Benni Mack merged patch set 6 11/01/24, 19:24