Review main Merged Breaking

86721[!!!][TASK] Remove support for arrays returned by `readFileContent()` in external parsers

Andreas Kienast CR +2 V +2 Easy +1 −13 updated 10/24/24, 07:31

Commit message

External parsers for Indexed Search were allowed to return an array via
`readFileContent()`, which was converted to an instance of
`IndexingDataAsString`. This fallback has been removed, anything that is
not of type `IndexingDataAsString` is ignored.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 10/23/24, 18:53

  2. core-ci voted on patch set 1 V +1 10/23/24, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68480

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/23/24, 21:06

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 10/24/24, 06:50

  5. Andreas Kienast voted on patch set 1 CR +2 V +2 10/24/24, 07:31

  6. Andreas Kienast merged patch set 2 10/24/24, 07:31