86725[BUGFIX] Use platform specific doctrine/dbal schema comparators
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/core/Classes/Database/Schema/Comparator.php+56 −24
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+7 −4
- typo3/sysext/core/Classes/Database/Schema/SchemaDiff.php+12 −19
- typo3/sysext/core/Classes/Database/Schema/TableDiff.php+10 −10
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php1+143 −69
Review log 1317
-
Benjamin Franzke uploaded patch set 1 10/24/24, 05:02
-
core-ci voted on patch set 1 V -1 10/24/24, 05:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68503
-
Benjamin Franzke uploaded patch set 2
V -110/24/24, 09:11 -
core-ci voted on patch set 2 V -1 10/24/24, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68518
-
Benjamin Franzke uploaded patch set 3
V -110/24/24, 09:27 -
core-ci voted on patch set 3 V +1 10/24/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68522
-
Benjamin Franzke uploaded patch set 4
V +110/24/24, 16:19 -
Benjamin Franzke uploaded patch set 5 10/24/24, 16:20
-
Benjamin Franzke commented on patch set 5 10/24/24, 16:21
-
core-ci voted on patch set 5 V +1 10/24/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68566
-
Garvin Hicking commented on patch set 5 V +1 10/24/24, 21:23
Can't comment on the code itself atm. But using this patch, my ddev installation (mysql:8.0) now no longer reports circular tries of a utf8mb4->"" mismatch. My settings.php: ``` 'DB' => [ 'Connections' => [ 'Default' => [ 'charset' => 'utf8mb4', 'driver' => 'mysqli', ], ], ], ``` My additional.php: ``` 'DB' => [ 'Connections' => [ 'Default' => [ 'charset' => 'utf8mb4', 'dbname' => 'db', 'driver' => 'mysqli', 'host' => 'db', 'password' => 'db', 'port' => '3306', 'user' => 'db', ], ], ], ``` -
Stefan Bürk commented on patch set 5 CR -1 11/04/24, 08:49
Reviewing ... -
Stefan Bürk commented on patch set 5 CR +1 V +1 11/04/24, 09:15
Reply
Done -
Garvin Hicking voted on patch set 5 CR +1 11/04/24, 09:26
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 11/04/24, 10:24
-
Benni Mack voted on patch set 5 CR +1 11/04/24, 10:30
-
Benjamin Franzke merged patch set 6 11/04/24, 10:53
SchemaMigratorTest.php:63