Review main Merged Breaking

86727[!!!][TASK] Remove deprecated `MathUtility::convertToPositiveInteger()`

Andreas Kienast CR +2 V +2 Easy +2 −28 updated 10/24/24, 11:18

Commit message

The following PHP static class method that has previously been marked as
deprecated for v13 has been removed:

- `\TYPO3\CMS\Core\Utility\MathUtility::convertToPositiveInteger()`

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 913

  1. Andreas Kienast uploaded patch set 1 10/24/24, 06:59

  2. Andreas Kienast updated the commit message in patch set 2 10/24/24, 07:01

  3. Andreas Kienast uploaded patch set 3 10/24/24, 07:05

  4. Andreas Kienast uploaded patch set 4 10/24/24, 07:06

  5. core-ci voted on patch set 1 V -1 10/24/24, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68505

  6. core-ci voted on patch set 2 V -1 10/24/24, 07:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68506

  7. Andreas Kienast uploaded patch set 5 10/24/24, 07:09

  8. core-ci voted on patch set 4 V +1 10/24/24, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68508

  9. core-ci voted on patch set 5 V +1 10/24/24, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68509

  10. Thomas Hohn voted on patch set 5 CR +1 V +1 10/24/24, 08:09

  11. Christian Kuhn voted on patch set 5 CR +1 V +1 10/24/24, 11:17

  12. Christian Kuhn voted on patch set 5 CR +2 V +2 10/24/24, 11:18

  13. Christian Kuhn merged patch set 6 10/24/24, 11:18