Review main Merged

86728[TASK] Add EXT:styleguide TCA datetime example with upper/lower range

Garvin Hicking CR +2 V +2 Easy +13 −1 updated 10/24/24, 13:17

Commit message

Currently only an example for a lower range datetime exists. We
should have one with upper+lower set to verify issues like in
issue #105400.

(Note that inputdatetime_34 is placed after inputdatetime_11, and not
at the end, due to its logical ordering next to it)

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Garvin Hicking uploaded patch set 1 10/24/24, 07:48

  2. core-ci voted on patch set 1 V +1 10/24/24, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68510

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 10/24/24, 08:30

  4. Christian Kuhn commented on patch set 1 10/24/24, 13:09

    tx_styleguide_elements_basic.php:368

    it's a bit sad that both _11 and _34 don't generate good data by the generator and are empty ... guess its ok to accept the change, but we should probably have a look at the generator in general again.
  5. Christian Kuhn voted on patch set 1 CR +2 V +2 10/24/24, 13:09

  6. Christian Kuhn merged patch set 2 10/24/24, 13:17