Review main Merged Breaking

86729[!!!][TASK] Remove deprecated class DuplicationBehavior

Thomas Hohn CR +2 V +2 Hard +61 −219 updated 10/24/24, 11:16

Commit message

Removed the deprecated class:
`\TYPO3\CMS\Core\Resource\DuplicationBehavior`

Change signature of the following methods to be of type
`\TYPO3\CMS\Core\Resource\Enum\DuplicationBehavior`:

- `\TYPO3\CMS\Core\Resource\AbstractFile->copyTo()` arg 3
- `\TYPO3\CMS\Core\Resource\AbstractFile->moveTo()` arg 3
- `\TYPO3\CMS\Core\Resource\AbstractFile->rename()` arg 2
- `\TYPO3\CMS\Core\Resource\FileInterface->rename()` arg 2
- `\TYPO3\CMS\Core\Resource\FileReference->rename()` arg 2
- `\TYPO3\CMS\Core\Resource\Folder->addFile()` arg 3
- `\TYPO3\CMS\Core\Resource\Folder->addUploadedFile()` arg 2
- `\TYPO3\CMS\Core\Resource\Folder->copyTo()` arg 3
- `\TYPO3\CMS\Core\Resource\Folder->moveTo()` arg 3
- `\TYPO3\CMS\Core\Resource\InaccessibleFolder->addFile()` arg 3
- `\TYPO3\CMS\Core\Resource\InaccessibleFolder->addUploadedFile()` arg 2
- `\TYPO3\CMS\Core\Resource\InaccessibleFolder->copyTo()` arg 3
- `\TYPO3\CMS\Core\Resource\InaccessibleFolder->moveTo()` arg 3
- `\TYPO3\CMS\Core\Resource\ResourceStorage->addFile()` arg 4
- `\TYPO3\CMS\Core\Resource\ResourceStorage->addUploadedFile()` arg 4
- `\TYPO3\CMS\Core\Resource\ResourceStorage->copyFile()` arg 4
- `\TYPO3\CMS\Core\Resource\ResourceStorage->copyFolder()` arg 4
- `TYPO3\CMS\Core\Resource\ResourceStorage->moveFile()` arg 4
- `\TYPO3\CMS\Core\Resource\ResourceStorage->moveFolder()` arg 4
- `\TYPO3\CMS\Core\Resource\ResourceStorage->renameFile()` arg 3

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 912

  1. Thomas Hohn uploaded patch set 1 10/24/24, 07:57

  2. core-ci voted on patch set 1 V +1 10/24/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68511

  3. Garvin Hicking updated the commit message in patch set 2 V +1 10/24/24, 08:47

  4. Garvin Hicking commented on patch set 2 10/24/24, 08:48

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:19

    alphabetical ordering here is (also in current state) wrong. We'll need to pick one patch to fix this, to not create an additional merge conflict of others? :-)
  5. core-ci voted on patch set 2 V +1 10/24/24, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68515

  6. Andreas Kienast uploaded patch set 3 V +1 10/24/24, 09:04

  7. Andreas Kienast commented on patch set 3 10/24/24, 09:04

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:19 Reply

    Done
  8. Andreas Kienast voted on patch set 3 CR +1 V +1 10/24/24, 09:07

  9. core-ci voted on patch set 3 V +1 10/24/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68516

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 10/24/24, 09:15

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 10/24/24, 11:16

  12. Christian Kuhn merged patch set 4 10/24/24, 11:16