86730[BUGFIX] Validate date ranges correctly
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 4
Review log 2230
Show 35 earlier messages
-
Andreas Kienast uploaded patch set 1 10/24/24, 08:08
-
core-ci voted on patch set 1 V +1 10/24/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68512
-
Andreas Kienast uploaded patch set 2
V +110/24/24, 08:21 -
core-ci voted on patch set 2 V +1 10/24/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68513
-
Andreas Kienast uploaded patch set 3
V +110/24/24, 08:35
-
core-ci voted on patch set 3 V +1 10/24/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68514
-
Garvin Hicking voted on patch set 3 CR +1 V +1 10/24/24, 08:51
-
Benjamin Franzke commented on patch set 3 CR -1 10/25/24, 05:50
-
Benjamin Franzke commented on patch set 3 10/29/24, 13:59
form-engine-validation.ts:265ReplyVerified this to be incorrect if the server is not using UTC. Example: Server timezone: Europe/Berlin (/etc/php.ini `timezone=Europe/Berlin`) Column: tx_styleguide_elements_basic.inputdatetime_34 Minimum timestamp: 1627208536 UTC: So 25. Jul 10:22:16 UTC 2021 Localtime min: So 25. Jul 12:22:16 CEST 2021 That means the user should not be allowed to set an hour earlier than `12:22` of the 25th of july 2021 for a server with timezone `Europe/Berlin`. But a user can enter anything >10:22, because the validation assumes that the server is using UTC, and therefore does not respect the UTC+2 offset of the timezone at that date. -
Benjamin Franzke uploaded patch set 4
CR +1V +110/29/24, 16:05 -
Benjamin Franzke commented on patch set 4 10/29/24, 16:05
form-engine-validation.ts:265ReplyDone -
Benjamin Franzke voted on patch set 4 CR +1 V +1 10/29/24, 16:06
-
core-ci voted on patch set 4 V +1 10/29/24, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68797
-
Garvin Hicking commented on patch set 4 10/29/24, 16:23
AbstractNode.php:156Would this one need a (int) casting like in https://review.typo3.org/c/Packages/TYPO3.CMS/+/86701/2..3, too? (same with 'upper' below 'lower') -
Benjamin Franzke uploaded patch set 5
CR +1V +110/29/24, 17:23 -
Benjamin Franzke commented on patch set 5 10/29/24, 17:23
AbstractNode.php:156ReplyI don't think so (also not in the other case), but let's do so (for consistency and safety) -
Benjamin Franzke voted on patch set 5 CR +1 V +1 10/29/24, 17:23
-
core-ci voted on patch set 5 V +1 10/29/24, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68799
-
Andreas Kienast uploaded patch set 6
CR +1V +110/30/24, 09:00 -
core-ci voted on patch set 6 V +1 10/30/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68832
-
Benjamin Franzke commented on patch set 6 CR +1 V +1 10/30/24, 09:16
To be used together with 86701: [BUGFIX] Use correct dataset identifier for date ranges | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86701 -
Andreas Kienast commented on patch set 6 10/30/24, 09:26
ALARM :Pform-engine-validation.ts:283upper -
Andreas Kienast commented on patch set 7
CR +1V +110/30/24, 09:27Published edit on patch set 6. -
Andreas Kienast commented on patch set 7 10/30/24, 09:27
form-engine-validation.ts:283ReplyDone -
Andreas Kienast uploaded patch set 8 10/30/24, 09:30
-
core-ci voted on patch set 7 V +1 10/30/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68835
-
core-ci voted on patch set 8 V +1 10/30/24, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68836
-
Garvin Hicking voted on patch set 8 CR +1 V +1 10/30/24, 09:39
-
Benjamin Franzke voted on patch set 8 CR +2 V +2 10/30/24, 11:44
-
Benjamin Franzke merged patch set 9 10/30/24, 11:56
form-engine-validation.ts:265