86731[BUGFIX] Parse csp.yaml with placeholders
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Markus Sommer +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Markus Sommer +1
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1316
-
Sebastian Iffland uploaded patch set 1 10/24/24, 09:32
-
Markus Sommer voted on patch set 1 CR +1 10/24/24, 09:36
-
Markus Sommer voted on patch set 1 V +1 10/24/24, 09:36
-
core-ci voted on patch set 1 V +1 10/24/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68523
-
Sebastian Iffland updated the commit message in patch set 2
CR +1V +110/24/24, 15:22 -
core-ci voted on patch set 2 V +1 10/24/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68556
-
Garvin Hicking updated the commit message in patch set 3
V +110/24/24, 15:55 -
Garvin Hicking commented on patch set 3 10/24/24, 15:56
(adjusted the commit message to contain linebreaks and tried some rephrasing, hope that's ok for you) -
Sebastian Iffland commented on patch set 3 10/24/24, 15:58
Reply
thanks a bunch! -
core-ci voted on patch set 3 V +1 10/24/24, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68561
-
Markus Sommer voted on patch set 3 CR +1 V +1 10/24/24, 16:46
-
Garvin Hicking commented on patch set 3 V +1 10/24/24, 19:10
This works for me. However I'd like @oliver.hader@typo3.org to check it out because I'm unsure if it was a conscious decisions to only specify "imports" processing so far (security?!). Not sure fore example if resolving the ENV vars could lead to disclosure of the variables in the CSP logger / resolving GUI, or in the emitted HTTP headers. You could theoretically create CSPs then to reveal any ENV setting, as long as you are able to access the YAML file. I suppose those are usually system maintainers, but still my spidey sense is tingling. -
Oliver Hader commented on patch set 3 10/28/24, 15:20
I'll have a look soon... -
Oliver Hader voted on patch set 3 CR +2 V +2 10/29/24, 08:38
-
Benni Mack voted on patch set 3 CR +1 V +1 10/29/24, 09:13
-
Oliver Hader merged patch set 4 10/29/24, 09:15