Review main Merged Breaking

86769[!!!][TASK] Remove support for instantiating IconRegistry in ext_localconf.php

Nikita Hovratov CR +2 V +2 Easy +4 −3 updated 10/24/24, 16:36

Commit message

Instantiation of IconRegistry in ext_localconf.php has been previously
deprecated in TYPO3 v13. Instead of a deprecation log entry, a PHP
\RuntimeException will now be thrown and stop code execution.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 57

  1. Nikita Hovratov uploaded patch set 1 10/24/24, 15:52

  2. Christian Kuhn updated the commit message in patch set 2 10/24/24, 15:54

  3. core-ci voted on patch set 1 V +1 10/24/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68559

  4. core-ci voted on patch set 2 V +1 10/24/24, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68560

  5. Thomas Hohn voted on patch set 2 CR +1 V +1 10/24/24, 16:33

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 10/24/24, 16:36

  7. Christian Kuhn merged patch set 3 10/24/24, 16:36