Review main Merged

86771[BUGFIX] Remove slow MySQL table index queries

Benjamin Franzke CR +2 V +2 Normal +31 −160 updated 11/04/24, 10:13

Commit message

Querying `information_schema.STATISTICS` for every index
(that has already been fetched from `information_schema.STATISTICS`)
causes superfluous queries and slows down database comparision
drastically (~350 uneeded queries), neglecting the performance
improvements that have been applied upstream:
https://github.com/doctrine/dbal/pull/5268

The table index query has been introduced with #78024 to
parse the index prefix length into the column name.
It turns out this parsing can be done without additional
database queries since https://github.com/doctrine/dbal/pull/2412

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Benjamin Franzke uploaded patch set 1 10/25/24, 01:12

  2. core-ci voted on patch set 1 V +1 10/25/24, 01:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68568

  3. Benjamin Franzke uploaded patch set 2 V +1 10/25/24, 05:22

  4. core-ci voted on patch set 2 V +1 10/25/24, 05:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68581

  5. Stefan Bürk commented on patch set 2 CR -1 11/04/24, 09:27

    Reviewing ...
  6. Stefan Bürk commented on patch set 2 CR +1 V +1 11/04/24, 09:41

    Thanks for taking care of this. Investigating this to get rid of the trait (again) was on the list. Back than, simply provided it as replacement for the old (removed) event handling because did not get that historically during the DBAL 4 upgrade which was alredy huge enough.
  7. Stefan Bürk commented on patch set 2 11/04/24, 09:41

    Reply

    Done
  8. Andreas Kienast voted on patch set 2 CR +1 V +1 11/04/24, 09:58

  9. Benjamin Franzke voted on patch set 2 CR +2 V +2 11/04/24, 10:04

  10. Benjamin Franzke merged patch set 3 11/04/24, 10:13