Review main Merged Breaking

86772[!!!][TASK] Remove deprecated `PageRepository->enableFields()`

Thomas Hohn CR +2 V +2 Easy +4 −37 updated 10/25/24, 09:33

Commit message

The following PHP class method that has previously been marked as
deprecated for v13 has been removed:

- `\TYPO3\CMS\Frontend\Page\PageRepository->enableFields()`

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1114

  1. Thomas Hohn uploaded patch set 1 10/25/24, 04:33

  2. Thomas Hohn updated the commit message in patch set 2 10/25/24, 04:34

  3. core-ci voted on patch set 1 V +1 10/25/24, 04:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68576

  4. core-ci voted on patch set 2 V +1 10/25/24, 04:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68577

  5. Garvin Hicking commented on patch set 2 10/25/24, 07:37

    PageRepository.php:138

    Maybe this can be brushed up too and adapted to the "new way" to not leave it as a outdated leftover?
  6. Thomas Hohn commented on patch set 2 10/25/24, 07:47

    PageRepository.php:138 Reply

    I guess @benni@typo3.org might have a better say on what the correct text should be?
  7. Benni Mack commented on patch set 2 10/25/24, 07:57

    PageRepository.php:138 Reply

    The Event is called "ModifyDefaultConstraintsForDatabaseQueryEvent" and now within getDefaultConstraints" - the rest is kept the same.
  8. Thomas Hohn commented on patch set 2 10/25/24, 07:58

    PageRepository.php:138 Reply

    Acknowledged
  9. Thomas Hohn uploaded patch set 3 V +1 10/25/24, 08:00

  10. core-ci voted on patch set 3 V +1 10/25/24, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68586

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 10/25/24, 09:09

  12. Garvin Hicking commented on patch set 3 CR +1 V +1 10/25/24, 09:33

    great, thanks for that detail!
  13. Garvin Hicking voted on patch set 3 CR +2 V +2 10/25/24, 09:33

  14. Garvin Hicking merged patch set 4 10/25/24, 09:33