86773[BUGFIX] Sync language of inline children on copy
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- André Buchmann +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- André Buchmann +1
- core-ci +1 CI
Issues 4
- Bug #89787Copying element with IRRE element from one language to another
- Task #104956Add test for langugae behaviour of inline children on copy
- Bug #75400Related child elements don't get correct sys_language_uid during localization of parent record
- Bug #39054Copied Content Elements incorrectly inherit language
Files 15
- typo3/sysext/core/Classes/DataHandling/DataHandler.php3+36 −5
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/copyParentContentToDiffLanguageWAllChildren.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php+10 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/DataSet/copyParentContentToDiffLanguageWAllChildren.csv2new+67 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/ActionTest.php+10 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/DataSet/copyParentContentToDiffLanguageWAllChildren.csvnew+67 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/ActionTest.php+36 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublishAll/DataSet/copyParentContentToDiffLanguageWAllChildren.csvnew+67 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublishAll/ActionTest.php+34 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php+13 −7
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyParentContentToDiffLanguageWAllChildren.csv1+3 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/ActionTest.php+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/copyParentContentToDiffLanguageWAllChildren.csvnew+61 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/ActionTest.php+41 −11
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionTestCase.php+3 −7
Review log 4257
Show 2432 earlier messages
-
Astrid Haubold uploaded patch set 1 10/25/24, 08:03
-
Astrid Haubold rebased onto patch set 2 10/25/24, 08:13
-
core-ci voted on patch set 1 V -1 10/25/24, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68587
-
core-ci voted on patch set 2 V -1 10/25/24, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68589
-
Astrid Haubold uploaded patch set 3
V -111/01/24, 11:57 -
core-ci voted on patch set 3 V -1 11/01/24, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68959
-
Astrid Haubold uploaded patch set 4
V -112/12/24, 11:55 -
core-ci voted on patch set 4 V +1 12/12/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71027
-
Benni Mack commented on patch set 4 12/12/24, 16:49
Great work so far!DataHandler.php:3493do we also need to adapt the l10n_parent field? -
Astrid Haubold commented on patch set 4 12/13/24, 10:43
DataHandler.php:3493ReplyI don't think so: imo a connection to the original language version is not expected when copy command is used rather than localize or copyToLanguage. This is also current behaviour for the parent record. The aim of this fix is to make child records behave in the same way as the parent already does. -
Benni Mack commented on patch set 4 12/13/24, 14:42
DataHandler.php:3493ReplyDone -
Astrid Haubold uploaded patch set 5
V +112/16/24, 15:15 -
core-ci voted on patch set 5 V +1 12/16/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71201
-
Eric Harrer voted on patch set 5 CR +1 V +1 12/20/24, 12:21
-
André Buchmann commented on patch set 5 CR -1 V +1 12/20/24, 12:34
[BUGFIX] Sync language of inline elements after copynot only the -
Jo Hasenau voted on patch set 5 CR +1 V +1 12/20/24, 12:35
-
Astrid Haubold uploaded patch set 6
CR +1V +112/20/24, 13:14 -
core-ci voted on patch set 6 V +1 12/20/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71508
-
André Buchmann voted on patch set 6 CR +1 V +1 12/20/24, 13:58
-
Eric Harrer voted on patch set 6 CR +1 V +1 12/22/24, 19:27
-
Benni Mack voted on patch set 6 CR +1 01/08/25, 11:27
-
Christian Kuhn commented on patch set 6 CR -1 01/08/25, 11:34
working on in. -
Christian Kuhn uploaded patch set 7
CR +1V +101/09/25, 11:43 -
Christian Kuhn voted on patch set 7 CR -1 01/09/25, 11:43
-
core-ci voted on patch set 7 V +1 01/09/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72134
-
Christian Kuhn commented on patch set 7 01/09/25, 13:43
copyParentContentToDiffLanguageWAllChildren.csv:19this shows that inline children now receive the same sys_language_uid when a parent element is copied to a different language using 'copy' DH command which 'copyToLanguage' already did: this .csv and copyParentContentToLanguageWAllChildren.csv are now nearly identical except the [Translate to ...] prefixes. -
Christian Kuhn uploaded patch set 8
CR -1V +101/09/25, 15:39 -
Christian Kuhn voted on patch set 8 CR -1 01/09/25, 15:40
-
core-ci voted on patch set 8 V +1 01/09/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72149
-
Christian Kuhn uploaded patch set 9
CR -1V +101/09/25, 16:14 -
Christian Kuhn voted on patch set 9 CR -1 01/09/25, 16:14
-
core-ci voted on patch set 9 V +1 01/09/25, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72152
-
Christian Kuhn commented on patch set 9 01/09/25, 16:22
copyParentContentToDiffLanguageWAllChildren.csv:26having this {""sys_language_uid"":""""} for l18n_diffsource is fishy, isn't it? -
Christian Kuhn commented on patch set 9 01/09/25, 16:24
copyParentContentToDiffLanguageWAllChildren.csv:26Replyi'll add an @todo to the .csv. -
Christian Kuhn uploaded patch set 10
CR -1V +101/09/25, 16:27 -
Christian Kuhn voted on patch set 10 CR -1 01/09/25, 16:27
-
core-ci voted on patch set 10 V +1 01/09/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72153
-
Christian Kuhn uploaded patch set 11
CR -1V +101/09/25, 16:48 -
Christian Kuhn voted on patch set 11 CR -1 01/09/25, 16:48
-
core-ci voted on patch set 11 V +1 01/09/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72154
-
Christian Kuhn uploaded patch set 12
CR -1V +101/09/25, 16:55 -
Christian Kuhn updated the commit message in patch set 13 01/09/25, 16:57
-
core-ci voted on patch set 12 V +1 01/09/25, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72155
-
core-ci voted on patch set 13 V +1 01/09/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72156
-
Christian Kuhn updated the commit message in patch set 14
V +101/09/25, 17:16 -
Christian Kuhn commented on patch set 14 01/09/25, 17:16
Reply
Done -
Christian Kuhn uploaded patch set 15 01/09/25, 17:17
-
core-ci voted on patch set 14 V +1 01/09/25, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72157
-
core-ci voted on patch set 15 V +1 01/09/25, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72158
-
Christian Kuhn voted on patch set 15 CR +1 V +1 01/09/25, 17:27
-
Benni Mack voted on patch set 15 CR +1 01/10/25, 08:30
-
André Buchmann commented on patch set 15 CR +1 V +1 01/10/25, 09:44
Thank you Lolli for improving the patch. Tested it successfully -
Astrid Haubold commented on patch set 15 01/10/25, 09:53
I think as author I'm not supposed to vote, but had a look at the changes: great as far as I can see. Thank you @lolli@schwarzbu.ch for all your work and useful feedback! -
Benni Mack voted on patch set 15 CR +2 V +2 01/10/25, 09:55
-
Benni Mack commented on patch set 15 01/10/25, 10:07
Thank you, Astrid + Lolli! -
Benni Mack merged patch set 16 01/10/25, 10:07