Review main Merged Breaking

86775[!!!][TASK] Remove deprecated methods in `TypoScriptFrontendController`

Thomas Hohn CR +2 V +2 Easy +4 −31 updated 10/25/24, 09:44

Commit message

The following PHP class methods that have previously been marked as
deprecated for v13 have been removed in class
`\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController`:

- `addCacheTags()`
- `getPageCacheTags()`

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 912

  1. Thomas Hohn uploaded patch set 1 10/25/24, 08:48

  2. core-ci voted on patch set 1 V +1 10/25/24, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68592

  3. Christian Kuhn commented on patch set 2 V +1 10/25/24, 08:59

    Published edit on patch set 1.
  4. Christian Kuhn voted on patch set 2 CR +1 V +1 10/25/24, 09:00

  5. core-ci voted on patch set 2 V +1 10/25/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68595

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/25/24, 09:33

  7. Simon Schaufelberger commented on patch set 2 10/25/24, 09:37

    I'll rebase this one
  8. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 10/25/24, 09:38

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/25/24, 09:38

  10. Christian Kuhn commented on patch set 3 CR +2 V +2 10/25/24, 09:39

    Reply

    Done
  11. core-ci voted on patch set 3 V +1 10/25/24, 09:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68606

  12. Christian Kuhn merged patch set 4 10/25/24, 09:44