Review main Merged

86776[DOCS] Improve example for rendering record objects in PAGEVIEW

Karsten Nowak CR +2 V +2 Easy +6 −1 updated 10/25/24, 16:28

Commit message

Don't use `{record.fullType}` for the `typoScriptObjectPath`
due to avoid errors if no rendering for the CType is defined in
TypoScript. Better use `{record.mainType}`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1521

  1. Karsten Nowak uploaded patch set 1 10/25/24, 08:50

  2. Mathias Brodala commented on patch set 1 10/25/24, 08:54

    Can we mention "tt_content" for the specific example somewhere for clarity? Right now it's rather obscure without looking up the record resolving feature in general.
  3. core-ci voted on patch set 1 V +1 10/25/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68593

  4. Nikita Hovratov voted on patch set 1 CR +1 V +1 10/25/24, 09:09

  5. Simon Schaufelberger updated the commit message in patch set 2 CR +1 V +1 10/25/24, 09:11

  6. Nikita Hovratov commented on patch set 1 CR +1 V +1 10/25/24, 09:13

    Reply

    imho we need another ViewHelper for rendering a record. Everything else should be internal. I think there was a patch with "RenderBlockViewHelper" don't know if this was about exactly this use case. But, yes. We could mention in a sentence, what the example actually does.
  7. Nikita Hovratov updated the commit message in patch set 3 10/25/24, 09:13

  8. core-ci voted on patch set 2 V +1 10/25/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68599

  9. Nikita Hovratov uploaded patch set 4 10/25/24, 09:20

  10. core-ci voted on patch set 3 V +1 10/25/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68600

  11. Nikita Hovratov commented on patch set 4 10/25/24, 09:21

    Reply

    Done
  12. core-ci voted on patch set 4 V +1 10/25/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68601

  13. Nikita Hovratov voted on patch set 4 CR +1 V +1 10/25/24, 09:29

  14. Karsten Nowak uploaded patch set 5 CR +1 V +1 10/25/24, 09:32

  15. core-ci voted on patch set 5 V +1 10/25/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68605

  16. Nikita Hovratov uploaded patch set 6 V +1 10/25/24, 09:44

  17. Nikita Hovratov voted on patch set 6 CR +1 V +1 10/25/24, 09:46

  18. core-ci voted on patch set 6 V +1 10/25/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68607

  19. Benni Mack voted on patch set 6 CR +1 V +1 10/25/24, 09:54

  20. Garvin Hicking voted on patch set 6 CR +2 V +2 10/25/24, 16:06

  21. Garvin Hicking merged patch set 7 10/25/24, 16:28