86776[DOCS] Improve example for rendering record objects in PAGEVIEW
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1521
-
Karsten Nowak uploaded patch set 1 10/25/24, 08:50
-
Mathias Brodala commented on patch set 1 10/25/24, 08:54
Can we mention "tt_content" for the specific example somewhere for clarity? Right now it's rather obscure without looking up the record resolving feature in general. -
core-ci voted on patch set 1 V +1 10/25/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68593
-
Nikita Hovratov voted on patch set 1 CR +1 V +1 10/25/24, 09:09
-
Simon Schaufelberger updated the commit message in patch set 2
CR +1V +110/25/24, 09:11 -
Nikita Hovratov commented on patch set 1 CR +1 V +1 10/25/24, 09:13
Reply
imho we need another ViewHelper for rendering a record. Everything else should be internal. I think there was a patch with "RenderBlockViewHelper" don't know if this was about exactly this use case. But, yes. We could mention in a sentence, what the example actually does. -
Nikita Hovratov updated the commit message in patch set 3 10/25/24, 09:13
-
core-ci voted on patch set 2 V +1 10/25/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68599
-
Nikita Hovratov uploaded patch set 4 10/25/24, 09:20
-
core-ci voted on patch set 3 V +1 10/25/24, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68600
-
Nikita Hovratov commented on patch set 4 10/25/24, 09:21
Reply
Done -
core-ci voted on patch set 4 V +1 10/25/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68601
-
Nikita Hovratov voted on patch set 4 CR +1 V +1 10/25/24, 09:29
-
Karsten Nowak uploaded patch set 5
CR +1V +110/25/24, 09:32 -
core-ci voted on patch set 5 V +1 10/25/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68605
-
Nikita Hovratov uploaded patch set 6
V +110/25/24, 09:44 -
Nikita Hovratov voted on patch set 6 CR +1 V +1 10/25/24, 09:46
-
core-ci voted on patch set 6 V +1 10/25/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68607
-
Benni Mack voted on patch set 6 CR +1 V +1 10/25/24, 09:54
-
Garvin Hicking voted on patch set 6 CR +2 V +2 10/25/24, 16:06
-
Garvin Hicking merged patch set 7 10/25/24, 16:28