Review main Merged Breaking

86791[!!!][TASK] Remove fallback of comma-separated list for `columnsOnly`

Oli Bartsch CR +2 V +2 Easy +1 −12 updated 10/25/24, 13:35

Commit message

Passing a comma-separated list as value for
the `columnsOnly` parameter (used when building
links to FormEngine) has been deprecated in v13.

The corresponding fallback is now removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 10/25/24, 12:27

  2. core-ci voted on patch set 1 V +1 10/25/24, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68625

  3. Thomas Hohn commented on patch set 1 10/25/24, 12:56

    toFormEngine should be to FormEngine in commit msg right?
  4. Benni Mack commented on patch set 1 CR -2 10/25/24, 12:58

    Why backporting this in 13.4 and 12.4?
  5. Oli Bartsch updated the commit message in patch set 2 V +1 10/25/24, 13:02

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Oli Bartsch commented on patch set 2 10/25/24, 13:02

    Reply

    Quite important change I think. ;)
  7. core-ci voted on patch set 2 V +1 10/25/24, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68630

  8. Benni Mack voted on patch set 2 CR +1 V +1 10/25/24, 13:35

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 10/25/24, 13:35

  10. Christian Kuhn merged patch set 3 10/25/24, 13:35