86792[!!!][TASK] Remove deprecated <INCLUDE_TYPOSCRIPT:
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 3
Files 66
- Build/Sources/TypeScript/backend/code-editor/stream-parser/typoscript.ts+0 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_pagetsconfig.xlf+0 −6
- typo3/sysext/backend/Resources/Public/JavaScript/code-editor/stream-parser/typoscript.js+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/ConditionIncludeTyposcriptInclude.phpdeleted+0 −29
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeTyposcriptInclude.phpdeleted+0 −26
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSourceAggregatorVisitor.php+1 −3
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSyntaxScannerVisitor.php+6 −15
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+0 −204
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/ImportOldLine.phpdeleted+0 −49
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/TokenType.php+0 −5
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LosslessTokenizer.php+6 −64
- typo3/sysext/core/Classes/TypoScript/Tokenizer/LossyTokenizer.php+1 −49
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst+1 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validIncludeTypoScriptA.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validIncludeTypoScriptB.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/includes.typoscript+0 −4
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario1/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/RelativeSub/subInclude.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/relative1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/relative2.typoscriptdeleted+0 −1
Show 46 more files
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/relative3.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario2/subInclude.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario3/setup1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario3/setup2.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/AutoSubDir1/auto1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/AutoSubDir1/auto2.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/AutoSubDir2/auto1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario4/setup1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario5/setup1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario5/setup2.foo.txtdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario5/setup3.typo3deleted+0 −2
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario6/SubDir/SubSubDir/subsub.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario6/SubDir/sub.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario6/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario7/SubDir/SubSubDir/subsub.setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario7/SubDir/sub.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/ExtImport/Scenario7/general.setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario1/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/RelativeSub/subInclude.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/relative1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/relative2.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/relative3.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario2/subInclude.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario3/setup1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario3/setup2.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/AutoSubDir1/auto1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/AutoSubDir1/auto2.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/AutoSubDir2/auto1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario4/setup1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario5/setup1.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario5/setup2.foo.txtdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/FileadminImport/Scenario5/setup3.typo3deleted+0 −2
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario1/invalidPathTraversalTarget.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario1/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario2/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario3/invalidPathTraversalTarget.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario3/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/Scenario4/setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTyposcript/InvalidImport/invalidPathTraversalTarget.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Visitor/IncludeTreeSyntaxScannerVisitorTest.php+1 −7
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php+0 −643
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.php+0 −20
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/IncludeNode/ConditionIncludeTyposcriptIncludeTest.phpdeleted+0 −46
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/Line/ImportOldLineTest.phpdeleted+0 −38
- typo3/sysext/core/Tests/Unit/TypoScript/Tokenizer/TokenizerInterfaceTest.php+12 −447
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_analyzer.xlf+0 −6
Review log 67
-
Christian Kuhn uploaded patch set 1 10/25/24, 13:10
-
core-ci voted on patch set 1 V +1 10/25/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68631
-
Anja Leichsenring voted on patch set 1 CR +1 V +1 10/26/24, 11:07
-
Garvin Hicking commented on patch set 1 CR +1 V +1 10/26/24, 12:10
Very good, I couldn't find leftovers apart from that minor commentstuff in `typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php`. I especially like the specific Tokenizer error-line, maybe that'll be helpful at some point for fractor or so. -
Christian Kuhn voted on patch set 1 CR +2 V +2 10/26/24, 12:12
-
Christian Kuhn commented on patch set 1 10/26/24, 12:12
thanks for reviews! -
Christian Kuhn merged patch set 2 10/26/24, 12:13