Review main Merged Breaking

86803[!!!][TASK] Remove legacy BE entry point handling

Christian Kuhn CR +2 V +2 Normal +2 −100 updated 10/28/24, 06:40

Commit message

Remove creation and handling of typo3/index.php
entry point.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 810

  1. Christian Kuhn uploaded patch set 1 10/26/24, 15:59

  2. core-ci voted on patch set 1 V +1 10/26/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68680

  3. Andreas Kienast uploaded patch set 2 V +1 10/26/24, 18:15

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 10/26/24, 18:15

  5. core-ci voted on patch set 2 V +1 10/26/24, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68681

  6. Andreas Kienast commented on patch set 2 10/26/24, 18:22

    To test this with ddev (assuming nginx-fpm): 1. edit `.ddev/nginx_full/nginx-site.conf` according to https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Deprecation-87889-TYPO3BackendEntrypointScriptDeprecated.html#nginx-configuration 2. ensure `#ddev-generated` is removed in that file 3. `ddev restart`
  7. Garvin Hicking voted on patch set 2 CR +1 V +1 10/26/24, 18:42

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/26/24, 19:26

  9. Andreas Kienast voted on patch set 2 CR +2 V +2 10/28/24, 06:40

  10. Andreas Kienast merged patch set 3 10/28/24, 06:40