Review main Merged

86806[BUGFIX] Handle empty field array in FormEngine

Oli Bartsch CR +2 V +2 Easy +47 −0 updated 11/04/24, 09:17

Commit message

There might be use cases, a record is requested
while the table and record type combination does
not contain any fields to render (empty showitem).

This happens, e.g. because a record used for
inline elements only does not define any showitem
by default but via corresponding overrideChildTca.
If such record is now requested without the parent
context, e.g. via link in the references table of
the element information view, a corresponding
message is displayed instead of a "undefined
array key" PHP warning.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 710

  1. Oli Bartsch uploaded patch set 1 10/28/24, 09:17

  2. core-ci voted on patch set 1 V +1 10/28/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68713

  3. Oli Bartsch rebased onto patch set 2 V +1 10/31/24, 07:50

  4. core-ci voted on patch set 2 V +1 10/31/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68894

  5. Oli Bartsch updated the commit message in patch set 3 V +1 10/31/24, 09:49

  6. core-ci voted on patch set 3 V +1 10/31/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68901

  7. Benni Mack voted on patch set 3 CR +1 V +1 10/31/24, 14:11

  8. Jochen Roth voted on patch set 3 CR +1 V +1 11/04/24, 08:57

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 11/04/24, 09:17

  10. Oli Bartsch merged patch set 4 11/04/24, 09:17