Review 12.4 Merged

86807[BUGFIX] Handle empty field array in FormEngine

Oli Bartsch CR +2 V +2 Easy +43 −0 updated 11/04/24, 09:18

Commit message

There might be use cases, a record is requested
while the table and record type combination does
not contain any fields to render (empty showitem).

This happens, e.g. because a record used for
inline elements only does not define any showitem
by default but via corresponding overrideChildTca.
If such record is now requested without the parent
context, e.g. via link in the references table of
the element information view, a corresponding
message is displayed instead of a "undefined
array key" PHP warning.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/28/24, 09:25

  2. core-ci voted on patch set 1 V +1 10/28/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68714

  3. Oli Bartsch uploaded patch set 2 V +1 10/28/24, 09:37

  4. core-ci voted on patch set 2 V +1 10/28/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68716

  5. Benjamin Franzke marked it work in progress 10/29/24, 17:41

  6. Oli Bartsch commented on patch set 2 11/04/24, 09:02

    This change is ready for review.
  7. Oli Bartsch voted on patch set 2 CR +2 V +2 11/04/24, 09:18

  8. Oli Bartsch merged patch set 3 11/04/24, 09:18