Review 12.4 Merged

86808[TASK] Remove orphan EXT:styleguide file

Oli Bartsch CR +2 V +2 Easy +0 −29 updated 10/28/24, 10:21

Commit message

By backporting #100937, a single file
was added for EXT:styleguide, which
however does not exist in v12. The
file is now removed again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 10/28/24, 09:36

  2. core-ci voted on patch set 1 V +1 10/28/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68715

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 10/28/24, 09:46

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 10/28/24, 09:52

    Could we rename this title to something like "remove orphan EXT:styleguide file" or so? It sounds as if ext:styleguide would be rejected to work with v12 otherwise?
  5. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 10/28/24, 10:12

  6. Oli Bartsch commented on patch set 2 10/28/24, 10:12

    Reply

    Done
  7. Garvin Hicking commented on patch set 2 CR +1 V +1 10/28/24, 10:13

    thx!
  8. core-ci voted on patch set 2 V +1 10/28/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68718

  9. Andreas Kienast voted on patch set 2 CR +2 V +2 10/28/24, 10:21

  10. Andreas Kienast merged patch set 3 10/28/24, 10:21