Review main Abandoned

86809[TASK] Remove EXT:extensionmanager as part of minimal usable system

Oli Bartsch CR -2 V 0 Easy +1 −2 updated 11/12/26, 16:07

Commit message

With #102935 EXT:extensionmanager is
optional and is therefore no longer
declared as part of the minimal
usable system.

Review

  • Code review CR -2
    • Oli Bartsch -2
    • Benjamin Franzke -1
    • Andreas Kienast -1
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 1

Review log 1112

  1. Oli Bartsch uploaded patch set 1 10/28/24, 10:18

  2. Garvin Hicking voted on patch set 1 CR +1 V +1 10/28/24, 10:21

  3. core-ci voted on patch set 1 V +1 10/28/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68719

  4. Oli Bartsch commented on patch set 1 CR -2 10/28/24, 10:24

    Unresolved

    Waiting for feedback regarding non-composer mode usage
  5. Andreas Kienast commented on patch set 1 CR -1 10/28/24, 10:26

    Install Tool checks twice whether `extensionmanager` is installed and adapts some behavior, which is not the case when this flag is removed.
  6. Garvin Hicking voted on patch set 1 CR 0 V 0 10/28/24, 10:38

  7. Benjamin Franzke commented on patch set 1 CR -1 10/28/24, 10:51

    Before we can actually address that, we need to fix typo3/sysext/core/Classes/Package/PackageManager.php to actually honor `partOfMinimalUsableSystem` instead of `protected`, as otherwise this change would have not have any effect. I think it's fine to remove `partOfMinimalUsableSystem` for extensionmanager after that, but we need some more adaptions first: Remember: `partOfMinimalUsableSystem` affects what is loaded in our maintenance tool by default (in the `FailsafePackageManager) if `PackageStates.php` is missing. `typo3/sysext/install/Classes/Service/ClearTableService.php` will not be able to clear extensionmanager tables anymore, as this service uses the failsafe package manager instance to obtain tables to be cleared. This one would need to be adapted to use the lateBootService and check extensionmanager available withing the PackageManager of the full (symfony) dependency injection container. Also typo3/sysext/install/Classes/Controller/InstallerController.php needs to be adapted. I think we should also discuss typo3/sysext/extbase/composer.json and typo3/sysext/filelist/composer.json.
  8. Benni Mack commented on patch set 1 10/28/24, 13:17

    Reply

    Valid points. Some remarks from my side: - ClearTableService -> I think we should get rid of the tx_extensionmanager_domain_model_extension cleaning - extbase's composer.json -> look at the usages of LocalizationUtility and ImageService without people using EXT:extbase. I think this is an antipattern which we should resolve first, before removing extbase from the list. - EXT:filelist can be optional in v14, IMHO
  9. Christian Kuhn commented on patch set 1 11/11/24, 14:50

    Reply Unresolved

    Background: 'partOfMinimalUsableSystem' was designed for legacy mode back then to re-create a default PackageStates.php (i think it was some different file back then) if that file somehow vanished in a running instance. The goal was to establish a default file that gives a working backend to then allow loading further stuff using the extensionmanager. that's why extensionmanager is 'partOfMinimalUsableSystem' and why I did not remove that flag when i allowed having a composer based instance without that extension. imho, the entire thing could vanish if the extensionmanager would be integrated into install tool, which might be do-able nowadays and was totally out of scope with the huge extensionmanager codebase mess and all its extbase dependencies ... this area however continuously improved since for example benni and me cleaned up and removed so much stuff meanwhile.
  10. Benni Mack marked it work in progress 03/22/25, 12:33

  11. Benni Mack commented on patch set 1 11/12/26, 14:57

    Unresolved

    I think we can abandon this change because it doesn't need to included anymore already. The reason is: optional in Composer mode, always active in classic mode by design... right?
  12. Benni Mack abandoned the change 11/12/26, 16:07

    wont do