Review main Merged

86810[TASK] Add method FileReference::isType()

Oliver Hader CR +2 V +2 Easy +5 −0 updated 10/28/24, 11:22

Commit message

Issue #102032 introduced AbstractFile::isType() to handle the
newly introduced enums. However, since FileReference does not
extend AbstractFile, it has to be added there as well.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 10/28/24, 11:07

  2. Garvin Hicking updated the commit message in patch set 2 10/28/24, 11:09

  3. Oli Bartsch voted on patch set 2 CR +1 V +1 10/28/24, 11:11

  4. core-ci voted on patch set 1 V +1 10/28/24, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68720

  5. core-ci voted on patch set 2 V +1 10/28/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68721

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 10/28/24, 11:19

  7. Oliver Hader voted on patch set 2 CR +2 V +2 10/28/24, 11:22

  8. Oliver Hader merged patch set 3 10/28/24, 11:22