Review main Merged

86812[TASK] Extend lifetime of `tableoptions` and `collate` deprecation

Thomas Hohn CR +2 V +2 Easy +6 −5 updated 11/26/24, 16:27

Commit message

Since TYPO3 v13 the `tableoptions` array and `collate` sub-key has
been deprecated and triggers deprecation notices when migrated to
the new options.

Originally scheduled to remove the migration with TYPO3 v14 following
casual deprecation policiy, it has been decided to extend the lifetime
of the deprecation and migration to TYPO3 v15 or later as it does not
hurt to have the migration and deprecation in place.

This change modifies the code comments and depreceation changelog
entry to reflect the lifetime extending decision.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 2737

Show 712 earlier messages
  1. Thomas Hohn uploaded patch set 1 10/28/24, 13:09

  2. core-ci voted on patch set 1 V -1 10/28/24, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68726

  3. Benjamin Franzke commented on patch set 1 CR -1 10/28/24, 14:23

    This change does not just drop methods, it also removes handling of configuration options.

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:209

    This chapter deserved to be updated when removing handling of configuration options.
  4. Thomas Hohn uploaded patch set 2 CR -1 V -1 10/28/24, 17:51

  5. Thomas Hohn commented on patch set 1 10/28/24, 17:51

    Reply

    Acknowledged

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:209 Reply

    Acknowledged
  6. core-ci voted on patch set 2 V -1 10/28/24, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68736

  7. Thomas Hohn uploaded patch set 3 V -1 10/29/24, 06:35

  8. core-ci voted on patch set 3 V -1 10/29/24, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68760

  9. Thomas Hohn rebased onto patch set 4 V -1 10/29/24, 19:21

  10. core-ci voted on patch set 4 V +1 10/29/24, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68804

  11. Thomas Hohn uploaded patch set 5 V +1 10/30/24, 05:22

  12. core-ci voted on patch set 5 V +1 10/30/24, 05:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68822

  1. Chris Müller updated the commit message in patch set 6 V +1 11/04/24, 16:53

  2. core-ci voted on patch set 6 V +1 11/04/24, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69046

  3. Stefan Bürk commented on patch set 6 CR -1 11/05/24, 12:13

    Thanks @tho@gyldendal.dk for working on this. temp -1, working on the change ...

    ConnectionPool.php:233

    I would keep that cleanup (of unsupported option). However, the comment was wrong and should be rephrased.
  4. Stefan Bürk uploaded patch set 7 CR -1 V +1 11/05/24, 12:45

  5. Stefan Bürk commented on patch set 7 11/05/24, 12:48

    Reply

    I guess we should first get * 86878: [BUGFIX] Apply InnoDB as default to CREATE TABLE options | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86878 * 86880: [BUGFIX] Apply defaultTableOptions to CREATE TABLE DEFAULTS | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86880 in before merging that one. @ben@bnf.dev what do you think ?

    ConnectionPool.php:233 Reply

    Done

    ConfigurationStatus.php:285

    Good finding. We need a 13.4 only change afterwards to reflect that with the deprecation in 13.4. Let's keep that out here and create a pure 13.4 bugfix as dedicated change.
  6. core-ci voted on patch set 7 V +1 11/05/24, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69096

  7. Benjamin Franzke commented on patch set 7 11/05/24, 12:56

    Reply

    either way is fine for me. If this one is ready it can be merged before those fixes as well.
  8. Thomas Hohn commented on patch set 7 11/11/24, 12:09

    Reply

    I guess this once could get merged now :-)
  9. Benjamin Franzke uploaded patch set 8 V +1 11/11/24, 12:23

  10. Benjamin Franzke commented on patch set 8 CR -1 11/11/24, 12:28

    These are private methods. No need to mention them in the breaking.rst and commit message. No enduser could have used them, this makes the documentation less useful. The real change is the removal of configuration migration, which we should describe in detail

    ConnectionPool.php:179

    @stefan@buerk.tech I'm honestly not sure whether we should support configuration migration over two releases, like for upgrade wizards. What would the experience of a user updating from v12 to v14 look like? If I see things right they, the option would just be ignored without even noticing. (I don't know how we handled that in other deprecation removals in v14, it just came to my mind…)
  11. core-ci voted on patch set 8 V +1 11/11/24, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69304

  12. Stefan Bürk commented on patch set 8 11/11/24, 16:22

    Reply

    Ack. Deprecation are the options, not the "migration" methods.

    ConnectionPool.php:179 Reply

    Thought about the same. I tend to leave the migration for one more version, and modify the change to adjust the the removal version for now (like upgrade wizards). In the end, v12 instances can use the new options directly, in v13 the deprecation will be emitted .. I guess it may be better to extend that for one version, as not many may regonize or ignore this more or less. And it gives us time to overwirk for example ddev to provide that correctly within additional.php für v12+ (not done at the moment) and so on. Don't have a example at hand, but I remember that for removed option in some cases deprecation has been emitted in one version, and instead of a pure removal a Runtimeexception thrown not doing the migration (hard flag do it now). But for these settings, which are most likely not configured manually but added in old instances way back during creating the project/instance the first time. Should we delay it one version @ben@bnf.dev ?
  13. Benjamin Franzke commented on patch set 8 11/11/24, 16:26

    ConnectionPool.php:179 Reply

    if you ask me, yes. would also be in line with the prolonging that has been applied in > 86885: [TASK] Extend lifetime of legacy local and additional configuration migration | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86885 (initiated by Benni)
  14. Thomas Hohn commented on patch set 8 11/12/24, 05:17

    ConnectionPool.php:179 Reply

    So we leave this patch for now and I create a new patch - that states that the deprecations will be removed with TYPO3 15?
  15. Stefan Bürk commented on patch set 8 11/12/24, 07:50

    ConnectionPool.php:179 Reply

    > So we leave this patch for now and I create a new patch - that states that the deprecations will be removed with TYPO3 15? I would modify this change, remove the removal and rest file. Instead add the code comment changes and adjusting the deprecation rest-file to state the longer deprecation time. And make it a non breaking task with 13.4 backport. Would keep the relations (related) to the deprecation. Similar to > 86885: [TASK] Extend lifetime of legacy local and additional configuration migration | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86885
  16. Thomas Hohn commented on patch set 8 11/13/24, 08:35

    ConnectionPool.php:179 Reply

    So you want to update the original deprecation rest-file https://review.typo3.org/c/Packages/TYPO3.CMS/+/85670
  17. Stefan Bürk uploaded patch set 9 CR -1 V +1 11/26/24, 09:28

  18. core-ci voted on patch set 9 V +1 11/26/24, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70197

  19. Stefan Bürk commented on patch set 9 11/26/24, 09:45

    Reply

    Done

    ConnectionPool.php:179 Reply

    Extracted the `EXT:reports` change into a pre-patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/87234 and adopted this change to extend the deprecation lifetime.
  20. Stefan Bürk updated the commit message in patch set 10 V +1 11/26/24, 12:08

  21. core-ci voted on patch set 10 V +1 11/26/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70202

  22. Christian Kuhn voted on patch set 10 CR +1 V +1 11/26/24, 12:27

  23. Anja Leichsenring voted on patch set 10 CR +1 V +1 11/26/24, 14:54

  24. Stefan Bürk voted on patch set 10 CR +2 V +2 11/26/24, 16:01

  25. Stefan Bürk merged patch set 11 11/26/24, 16:27