Review 13.4 Merged

86817[BUGFIX] Parse csp.yaml with placeholders

Oliver Hader CR +2 V +2 Easy +1 −1 updated 10/29/24, 09:15

Commit message

Replace ENV variables in config/sites/*/csp.yaml.

Previously, a string like `https://%env(BASE_DOMAIN)%/`
was passed through without any placeholder substitution, because
the YamlFileLoader::PROCESS_PLACEHOLDERS flag was not set.

By omitting any flag, by default the loader is able to process
both imports and placeholder substitution.

This allows embedded ENV variables in the csp.yaml files to
be evaluated properly.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oliver Hader uploaded patch set 1 10/29/24, 08:28

  2. core-ci voted on patch set 1 V +1 10/29/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68764

  3. Oliver Hader voted on patch set 1 CR +2 V +2 10/29/24, 08:38

  4. Oliver Hader merged patch set 2 10/29/24, 09:15