Review main Abandoned

86828[BUGFIX] Ensure clean context for f:cObject viewhelper

Markus Klein CR 0 V 0 Easy +1 −1 updated 03/17/25, 19:56

Commit message

The viewhelper passes the current request on to
the ContentObjectRenderer. The request can be
an Extbase request, which causes subsequent
content rendering to fail, due to mangled controller/action
parameters.

The viewhelper must not pass along Extbase stuff,
so this patch removes the extbase attribute on
the request passed on to the ContentObjectRenderer.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1011

  1. Markus Klein uploaded patch set 1 10/29/24, 15:22

  2. core-ci voted on patch set 1 V +1 10/29/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68793

  3. Mathias Brodala voted on patch set 1 CR +1 10/29/24, 15:49

  4. Jörg Bösche voted on patch set 1 CR +1 11/01/24, 11:13

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/08/24, 10:13

  6. Thomas Hohn voted on patch set 1 CR +1 V +1 11/20/24, 07:50

  7. Garvin Hicking voted on patch set 1 CR +1 03/17/25, 14:22

  8. Markus Klein commented on patch set 1 CR -1 03/17/25, 15:28

    Due to the new facts that evolved today, I'll provide current repo-steps in the ticket and also re-test this on v13. gimme some minutes
  9. Markus Klein commented on patch set 1 CR -1 V -1 03/17/25, 19:55

    To be continued in v12 version only! see forge
  10. Markus Klein abandoned the change 03/17/25, 19:56