Review 12.4 Merged

86829[BUGFIX] Use correct dataset identifier for date ranges

Benjamin Franzke CR +2 V +2 Easy +16 −13 updated 10/30/24, 11:55

Commit message

Datetime fields can be configured to set a minimum date and a maximum
date. This apparently broke with the migration to flatpickr, which
dropped jQuery in the same run.

The data attributes are named `data-date-min-date` and
`data-date-max-date`, and therefore the dataset accessor must be
correctly camel-cased. Configured date ranges are transformed to valid
JavaScript `Date` objects and fed into flatpickr.

To ensure consistent date handling, the min and max range values
are now parsed into server localtime, to coincide with how
the date values are handled since #104309.

Also, a minor CSS bug is fixed that makes disallowed dates
distinguishable from dates in another months.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 34

  1. Benjamin Franzke uploaded patch set 1 10/29/24, 17:39

  2. core-ci voted on patch set 1 V +1 10/29/24, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68800

  3. Benjamin Franzke commented on patch set 1 CR +2 V +2 10/30/24, 11:46

    This change is ready for review.
  4. Benjamin Franzke merged patch set 2 10/30/24, 11:55