Review 12.4 Merged

86830[BUGFIX] Validate date ranges correctly

Benjamin Franzke CR +2 V +2 Normal +51 −12 updated 10/30/24, 11:56

Commit message

With the changes done in #104309, FormEngine works with `Date` objects
and not with timestamps anymore. This unfortunately broke the validation
in cases `lower` and/or `upper` ranges are defined as the values still
were treated as timestamps.

The code branches in the validation now have a separate check for input
fields of type `datetimepicker` and treat the comparison differently
and works with ISO8601 for the value and for the upper/lower range
values.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 47

  1. Benjamin Franzke uploaded patch set 1 10/29/24, 17:39

  2. core-ci voted on patch set 1 V +1 10/29/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68801

  3. Benjamin Franzke uploaded patch set 2 CR +1 V +1 10/30/24, 11:44

  4. Benjamin Franzke commented on patch set 2 CR +2 V +2 10/30/24, 11:44

    This change is ready for review.
  5. core-ci voted on patch set 2 V -1 10/30/24, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68847

  6. core-ci voted on patch set 2 V +1 10/30/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68847

  7. Benjamin Franzke merged patch set 3 10/30/24, 11:56