Review main Merged

86832[BUGFIX] Provide full raw record to content object rendering

Oli Bartsch CR +2 V +2 Easy +4 −5 updated 10/30/24, 16:12

Commit message

When calling the f:cObject Viewhelper by passing
a Record object as `data`, which is the case when
building frontend templates using the `page-content`
data processor, it is now ensured that the full
raw record data (all fields) are passed to the
content object rendering.

This is required for further data processors as
they would expect `$processedData['data']` to
contain the full raw record data.

An example is the ContentBlocksDataProcessor
of ext:content_blocks, which itself calls
RecordFactory to create a transformed record,
which however requires the raw input record
to contain all necessary fields, such as
the language field.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 10/30/24, 08:43

  2. core-ci voted on patch set 1 V +1 10/30/24, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68828

  3. Nikita Hovratov voted on patch set 1 CR +1 10/30/24, 09:10

  4. Nikita Hovratov voted on patch set 1 V +1 10/30/24, 09:25

  5. Nikita Hovratov uploaded patch set 2 CR +1 V +1 10/30/24, 09:36

  6. Nikita Hovratov voted on patch set 2 CR +1 V +1 10/30/24, 09:37

  7. core-ci voted on patch set 2 V +1 10/30/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68837

  8. Benni Mack commented on patch set 2 CR +1 V +1 10/30/24, 09:56

    perfect solution
  9. Oli Bartsch voted on patch set 2 CR +2 V +2 10/30/24, 16:11

  10. Oli Bartsch merged patch set 3 10/30/24, 16:12