Review 13.4 Merged

86833[TASK] Return string in FormEngine `integer` parsing

Andreas Kienast CR +2 V +2 Easy +14 −3 updated 10/30/24, 08:59

Commit message

The method `FormEngineValidation.processValue()` is declared to return a
`string`, but that's not always the case: in case for `integer` fields,
a real `number` is returned.

Fixing this reveals another misbehavior: if a number field contains the
value "42" and the field is updated to contain the value "0042", its
value normalized to the string value `'42'` again. Due to the strict
type check for value updates, the value is not considered as changed,
and therefore the "human-readable" field was not updated with the
normalized (formatted) value.

This commit therefore changes two things:

* string values are now returned when parsing `integer` fields
* the user facing field is now always updated to contain a clean value

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast uploaded patch set 1 10/30/24, 08:53

  2. core-ci voted on patch set 1 V +1 10/30/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68830

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 10/30/24, 08:59

  4. Andreas Kienast merged patch set 2 10/30/24, 08:59