Review main Merged

86834[BUGFIX] Prevent RTE CKEditor5 initialization race condition

Benjamin Franzke CR +2 V +2 Normal +42 −47 updated 10/30/24, 11:41

Commit message

Since #104135 DocumentReady does not await the `load` event and
therefore FormEngineValidation initialization could run before
CKEditor5 Element had rendered the <textarea> element.

Create the <textarea> element server side to ensure that initial
FormEngine queries can pick the element up. The same logic has
already been applied to the t3editor element.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 79

  1. Benjamin Franzke uploaded patch set 1 10/30/24, 10:17

  2. core-ci voted on patch set 1 V -1 10/30/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68839

  3. Benjamin Franzke uploaded patch set 2 V -1 10/30/24, 10:35

  4. Benjamin Franzke uploaded patch set 3 10/30/24, 10:38

  5. core-ci voted on patch set 3 V +1 10/30/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68842

  6. Andreas Kienast voted on patch set 3 CR +1 V +1 10/30/24, 10:56

  7. Garvin Hicking commented on patch set 3 CR +1 V +1 10/30/24, 10:59

    Good idea. Also works for me, and may prove beneficial in the future.
  8. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/30/24, 11:41

  9. Benjamin Franzke merged patch set 4 10/30/24, 11:41