86834[BUGFIX] Prevent RTE CKEditor5 initialization race condition
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/Sass/element/typo3-rte-ckeditor-ckeditor5.scss+4 −0
- Build/Sources/TypeScript/rte_ckeditor/ckeditor5.ts+21 −32
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+12 −6
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/ckeditor5.js+4 −9
Review log 79
-
Benjamin Franzke uploaded patch set 1 10/30/24, 10:17
-
core-ci voted on patch set 1 V -1 10/30/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68839
-
Benjamin Franzke uploaded patch set 2
V -110/30/24, 10:35 -
Benjamin Franzke uploaded patch set 3 10/30/24, 10:38
-
core-ci voted on patch set 3 V +1 10/30/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68842
-
Andreas Kienast voted on patch set 3 CR +1 V +1 10/30/24, 10:56
-
Garvin Hicking commented on patch set 3 CR +1 V +1 10/30/24, 10:59
Good idea. Also works for me, and may prove beneficial in the future. -
Benjamin Franzke voted on patch set 3 CR +2 V +2 10/30/24, 11:41
-
Benjamin Franzke merged patch set 4 10/30/24, 11:41