Review 12.4 Merged

86835[BUGFIX] Prevent RTE CKEditor5 initialization race condition

Benjamin Franzke CR +2 V +2 Normal +42 −47 updated 10/30/24, 11:41

Commit message

Since #104135 DocumentReady does not await the `load` event and
therefore FormEngineValidation initialization could run before
CKEditor5 Element had rendered the <textarea> element.

Create the <textarea> element server side to ensure that initial
FormEngine queries can pick the element up. The same logic has
already been applied to the t3editor element.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 34

  1. Benjamin Franzke uploaded patch set 1 10/30/24, 11:30

  2. core-ci voted on patch set 1 V +1 10/30/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68844

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 10/30/24, 11:41

  4. Benjamin Franzke merged patch set 2 10/30/24, 11:41