Review main Work in progress Orphaned

86837[WIP][BUGFIX] Generate timezone independent unix max timestamps

Benjamin Franzke CR 0 V 0 Easy +11 −11 updated 10/30/24, 12:30

Commit message

The returned value of `mktime` is dependent on the
date.timezone ini settings.
The intention to create maximum times based on maximum
integer capabilities therefore needs to be expressed
via `gmmktime` which produces reliable UTC-0 based timestamps.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/86837/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/37/86837/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Files 4

Review log 35

  1. Benjamin Franzke uploaded patch set 1 10/30/24, 12:20

  2. Benjamin Franzke uploaded patch set 2 10/30/24, 12:24

  3. core-ci voted on patch set 1 V +1 10/30/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68851

  4. Benjamin Franzke marked it work in progress 10/30/24, 12:28

  5. core-ci voted on patch set 2 V +1 10/30/24, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68852